Skip to content

Add/GitHub actions #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 5, 2021
Merged

Add/GitHub actions #17

merged 5 commits into from
Mar 5, 2021

Conversation

jeffpaul
Copy link
Member

Description of the Change

Adds linting action, action to deploy new releases to WP.org, and action to deploy changes to readme.txt and/or assets to WP.org.

Alternate Designs

n/a

Benefits

automates plugin management tasks

Possible Drawbacks

Readme/asset changes only to trunk or doing a release will trigger the deploy actions, but both should fail with no match on the WP.org SVN side (for now).

Verification Process

Waiting for PR to run thru checks to see what needs to be fixed before this can be merged.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a

Changelog Entry

### Added
- GitHub Actions (props @jeffpaul)

@jeffpaul jeffpaul added this to the 1.0.5 milestone Jan 14, 2021
@jeffpaul jeffpaul requested a review from tlovett1 January 14, 2021 07:36
@jeffpaul jeffpaul self-assigned this Jan 14, 2021
@jeffpaul jeffpaul requested a review from dinhtungdu January 26, 2021 19:57
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting actions are failing, we need to update the composer lock file and specify the JS folder.

dinhtungdu
dinhtungdu previously approved these changes Mar 4, 2021
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PHPCS job is failing due to the outdated composer.lock file, @jeffpaul can you please update it? After that, this is ready to be merged

@jeffpaul
Copy link
Member Author

jeffpaul commented Mar 5, 2021

@dinhtungdu looks correct now, minus some actual PHPCS errors, yeah?

@jeffpaul
Copy link
Member Author

jeffpaul commented Mar 5, 2021

Looks like those errors are all docs related, so I'm good merging this on and adding those in a subsequent PR.

@jeffpaul jeffpaul merged commit e512c99 into develop Mar 5, 2021
@jeffpaul jeffpaul deleted the add/github-actions branch August 13, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants