Skip to content

add Dockerfile #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2023
Merged

add Dockerfile #25

merged 2 commits into from
Feb 20, 2023

Conversation

bijeebuss
Copy link

I want to use this for something I'm working on but I don't want to install rust on my machine. This Dockerfile allows somebody to build the project with
docker build -t nostr-tool .
and run it with
docker run nostr-tool nostr-tool -r wss://nostr.oxtr.dev text-note -c "Hello World"
If you have a docker account you could publish the image so that anybody could run it without cloning the repo or installing rust with almost the same command.

@bijeebuss
Copy link
Author

I could just download the binary but having the cli in docker hub would make it easier to use as a composable app

@0xtrr
Copy link
Owner

0xtrr commented Feb 20, 2023

Thanks for the contribution @bijeebuss, LGTM! Can you also add docker instructions to the readme under the Install section?

@0xtrr
Copy link
Owner

0xtrr commented Feb 20, 2023

I'll also look into setting up an official docker image for nostr-tool on Dockerhub

@0xtrr 0xtrr merged commit ba0068c into 0xtrr:main Feb 20, 2023
@bijeebuss
Copy link
Author

If you are interested I can add my .devcontainer in another PR. This would allow anybody to run the project directly from github by clicking "open in codespaces" or do development in a container without needing to install rust on their machine.

@0xtrr
Copy link
Owner

0xtrr commented Feb 20, 2023

Cool, tbh I've never heard about .devcontainer and haven't used codespaces myself but I'm open to merge it if this is something that could be useful for someone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants