feat: add support of submitZKPResponseCrossChain #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-basiuk
force-pushed
the
feat/cross-chain-verify
branch
from
b75189b to
92b719b
Compare
…chainId found (#256) * fix: getStateContractAndProviderForId - throw error if no config for chainId found * provide chainId in config
vmidyllic
reviewed
Aug 22, 2024
vmidyllic
reviewed
Aug 27, 2024
volodymyr-basiuk
changed the title
daveroga
previously approved these changes
Sep 3, 2024
vmidyllic
reviewed
Sep 3, 2024
vmidyllic
requested changes
Sep 3, 2024
vmidyllic
previously approved these changes
Sep 4, 2024
daveroga
previously approved these changes
Sep 4, 2024
Kolezhniuk
requested changes
Sep 4, 2024
| request: ContractInvokeRequest, | ||
| responses: Map<string, ZeroKnowledgeProofResponse[]> | ||
| ): Promise<ContractInvokeResponse> { | ||
| const response: ContractInvokeResponse = { |
There was a problem hiding this comment.
I would change responses and response to more meaningfull
src/verifiable/presentation.ts
Outdated
| @@ -2,6 +2,7 @@ import { VerifiableConstants } from './constants'; | |||
| import { Options, Path } from '@iden3/js-jsonld-merklization'; | |||
| import { W3CCredential } from './credential'; | |||
| import { QueryMetadata } from '../proof'; | |||
| import { VerifiablePresentation } from '../iden3comm'; | |||
| import { JsonDocumentObject } from '../iden3comm'; | |||
There was a problem hiding this comment.
I guess
Suggested change
| import { JsonDocumentObject } from '../iden3comm'; | |
| import { VerifiablePresentation, JsonDocumentObject } from '../iden3comm'; |
| @@ -38,6 +38,7 @@ import { | |||
| DataPrepareHandlerFunc, | |||
| IContractRequestHandler, | |||
| IPackageManager, | |||
| JsonDocumentObjectValue, | |||
| issuerStateEthConfig.url = privadoTestRpcUrl; | ||
| issuerStateEthConfig.contractAddress = privadoTestStateContract; // privado test state contract | ||
|
|
||
| const memoryKeyStore = new InMemoryPrivateKeyStore(); |
There was a problem hiding this comment.
we have helper function registerKeyProvidersInMemoryKMS and getInMemoryDataStorage in helper.ts. It will help to make this test code size shorter
volodymyr-basiuk
dismissed stale reviews from daveroga and vmidyllic
via
cb1bd47
Kolezhniuk
approved these changes
Sep 4, 2024
vmidyllic
approved these changes
Sep 4, 2024
volodymyr-basiuk
added a commit
that referenced
this pull request
Sep 4, 2024
feat: add support of submitZKPResponseV2 and prepareTxArgsSubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.