-
Notifications
You must be signed in to change notification settings - Fork 11
Pre develop 0.7.0 imp witness #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xavi-pinsach
wants to merge
290
commits into
release_v0.7.0
Choose a base branch
from
pre-develop-0.7.0-imp-witness
base: release_v0.7.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lop-0.7.0-imp-witness
…tness Pre develop 0.7.0 + imp witness
* parallelize keccak * improve fixed const load * Cargo clippy, fmt and update * Cargo fmt --------- Co-authored-by: roger.taule <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
precompiles/keccakf/src/keccakf.rs:464
- The parameter name 'xxx' is non-descriptive; consider renaming it to a more meaningful name such as 'global_offset' to clearly indicate its purpose.
xxx: usize,
precompiles/keccakf/src/keccakf.rs:111
- Using a fixed size of 1 for splitting inputs_bits_slice may not align with the intended slot size; please confirm that this change correctly handles the input structure.
let (head, tail) = inputs_bits_slice.split_at_mut(1);
precompiles/keccakf/src/keccakf.rs:290
- Changing the slice start from index 1 to num_rows_constants modifies the trace buffer offset; ensure that num_rows_constants accurately represents the desired offset in this context.
let mut trace_slice = &mut trace.buffer[num_rows_constants..];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.