Skip to content

Pre develop 0.7.0 imp witness #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 290 commits into
base: release_v0.7.0
Choose a base branch
from

Conversation

xavi-pinsach
Copy link
Member

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

precompiles/keccakf/src/keccakf.rs:464

  • The parameter name 'xxx' is non-descriptive; consider renaming it to a more meaningful name such as 'global_offset' to clearly indicate its purpose.
            xxx: usize,

precompiles/keccakf/src/keccakf.rs:111

  • Using a fixed size of 1 for splitting inputs_bits_slice may not align with the intended slot size; please confirm that this change correctly handles the input structure.
            let (head, tail) = inputs_bits_slice.split_at_mut(1);

precompiles/keccakf/src/keccakf.rs:290

  • Changing the slice start from index 1 to num_rows_constants modifies the trace buffer offset; ensure that num_rows_constants accurately represents the desired offset in this context.
            let mut trace_slice = &mut trace.buffer[num_rows_constants..];

@RogerTaule RogerTaule changed the base branch from release_v0.7.0 to pre-develop-0.7.1 April 10, 2025 01:08
@RogerTaule RogerTaule changed the base branch from pre-develop-0.7.1 to release_v0.7.0 April 10, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants