Skip to content

chore: update axum and tokio in proving service #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

SantiagoPittella
Copy link
Collaborator

part of #1244

Could not update opentelemetry because tracing-opentelemetry is not updated yet. The PR in the tracing-opentelemetry that uses the new OTel version was merged a couple hours ago, but I don't know when it is going to be released. (tokio-rs/tracing-opentelemetry#196)

@SantiagoPittella SantiagoPittella added no docs This PR does not require an update to documentation files no changelog This PR does not require an entry in the `CHANGELOG.md` file labels Mar 25, 2025
Copy link
Collaborator

@igamigo igamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
It seems like tracing-opentelemetry was already released so maybe it can be updated as part of this PR as well (unless you prefer to do a separate PR)

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit 67c5ff8 into next Mar 25, 2025
14 checks passed
@bobbinth bobbinth deleted the santiagpittella-update-proving-service-deps branch March 25, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This PR does not require an entry in the `CHANGELOG.md` file no docs This PR does not require an update to documentation files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants