Skip to content

style(x509): format compatible code #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 29, 2025
Merged

style(x509): format compatible code #589

merged 16 commits into from
Mar 29, 2025

Conversation

0x676e67
Copy link
Owner

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors and modernizes certificate parsing APIs for x509 to improve consistency and inline performance.

  • Unifies function signatures to accept Into instead of AsRef<[u8]> for more flexible certificate input.
  • Introduces helper functions (parse_cert/parse_certs) and inlines functions for performance.
  • Updates error handling and wraps certificates in a new Certificate type.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/tls/x509/store.rs Refactors cert parsing functions and updates error handling.
src/tls/x509/mod.rs Introduces CertificateInput enum and conversion implementations.
src/tls/mod.rs Exports the new certificate types and interfaces.
src/client/http.rs Adjusts ssl_pinning signature to use the new certificate input type.
Comments suppressed due to low confidence (2)

src/tls/x509/store.rs:97

  • [nitpick] The parameter '_certs' is used later in the function call but is prefixed with an underscore, which typically indicates an unused parameter. Consider renaming it to 'certs' for clarity.
pub fn add_der_certs<'c, I>(self, _certs: I) -> Self

src/tls/x509/store.rs:111

  • [nitpick] The parameter '_certs' is used in the function despite the underscore prefix, which might mislead readers to think it is unused. Renaming it to 'certs' would improve code clarity.
pub fn add_pem_certs<'c, I>(self, _certs: I) -> Self

@0x676e67 0x676e67 merged commit a12a414 into main Mar 29, 2025
5 checks passed
@0x676e67 0x676e67 deleted the feat2 branch March 29, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant