-
Notifications
You must be signed in to change notification settings - Fork 41
style(x509): format compatible code #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors and modernizes certificate parsing APIs for x509 to improve consistency and inline performance.
- Unifies function signatures to accept Into instead of AsRef<[u8]> for more flexible certificate input.
- Introduces helper functions (parse_cert/parse_certs) and inlines functions for performance.
- Updates error handling and wraps certificates in a new Certificate type.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/tls/x509/store.rs | Refactors cert parsing functions and updates error handling. |
src/tls/x509/mod.rs | Introduces CertificateInput enum and conversion implementations. |
src/tls/mod.rs | Exports the new certificate types and interfaces. |
src/client/http.rs | Adjusts ssl_pinning signature to use the new certificate input type. |
Comments suppressed due to low confidence (2)
src/tls/x509/store.rs:97
- [nitpick] The parameter '_certs' is used later in the function call but is prefixed with an underscore, which typically indicates an unused parameter. Consider renaming it to 'certs' for clarity.
pub fn add_der_certs<'c, I>(self, _certs: I) -> Self
src/tls/x509/store.rs:111
- [nitpick] The parameter '_certs' is used in the function despite the underscore prefix, which might mislead readers to think it is unused. Renaming it to 'certs' would improve code clarity.
pub fn add_pem_certs<'c, I>(self, _certs: I) -> Self
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.