Skip to content

Adding Issue + PR Templates #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HarshCasper opened this issue Nov 18, 2020 · 5 comments
Closed

Adding Issue + PR Templates #830

HarshCasper opened this issue Nov 18, 2020 · 5 comments
Labels
area: infrastructure Project infrastructure further discussion required Discuss this on #zulip-terminal on chat.zulip.org high priority should be done as soon as possible

Comments

@HarshCasper
Copy link

Description

  • Add an Issue Template to streamline creating new Issues
  • Add a PR Template to document the changes implemented.

I would like to work on the same. This would make it easy for the reviewers to review the important points of the PR and make necessary request changes for them.

@neiljp
Copy link
Collaborator

neiljp commented Nov 19, 2020

@HarshCasper Thanks for opening this issue!

Re issue templates, I've noticed some other projects/repos now use the github feature of multiple templates, which helps triage feedback and focus the information requested. While we could support a basic issue template first, the breadth expected likely would make this noisy.

Re PR templates, this seems feasible to work on more directly, though needs review of the existing formats and requests that we typically make of contributors.

I'd welcome your work on this issue, though this may end up needing quite some fine-tuning by contributors more experienced with the project.

@neiljp neiljp added the further discussion required Discuss this on #zulip-terminal on chat.zulip.org label Nov 20, 2020
@neiljp
Copy link
Collaborator

neiljp commented Nov 20, 2020

I listed some example issue types in #zulip-terminal>Issue types for open discussion on chat.zulip.org.

@neiljp neiljp added the area: infrastructure Project infrastructure label Jan 28, 2021
@neiljp neiljp added the high priority should be done as soon as possible label May 13, 2021
@neiljp
Copy link
Collaborator

neiljp commented May 13, 2021

Now that ZT is becoming more popular, I'm bumping the priority of this.

@neiljp
Copy link
Collaborator

neiljp commented Apr 23, 2024

The pull request template has gone through various iterations already, so with #1488 or a followup, this issue will be resolved.

@neiljp
Copy link
Collaborator

neiljp commented May 29, 2024

Since we now have a structure in place from #1488, I'm going to close this - there will always be iterations we can do in future!

@neiljp neiljp closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: infrastructure Project infrastructure further discussion required Discuss this on #zulip-terminal on chat.zulip.org high priority should be done as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants