Skip to content

Add markers before stream names (& DMs) in message headers #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neiljp opened this issue Mar 22, 2023 · 9 comments · Fixed by #1386
Closed

Add markers before stream names (& DMs) in message headers #1348

neiljp opened this issue Mar 22, 2023 · 9 comments · Fixed by #1386
Assignees
Labels
area: UI General user interface update enhancement New feature or request good first issue Good for newcomers help wanted This issue should be clear enough to work on in progress
Milestone

Comments

@neiljp
Copy link
Collaborator

neiljp commented Mar 22, 2023

In the current UI, we don't use a prefix to indicate the type of stream (if relevant):

  • in the narrow title (eg. zulip-terminal: topic narrow)
  • in the 'Current message recipients' area (eg. zulip-terminal > some topic)
  • in the recipient header which is present in the message list in interleaved views (eg. scrolling through multiple topics in a stream narrow)

In contrast, see the stream list in the left panel, or the marker which we add when composing a message to different types of stream.

The characters used are looked up using STREAM_ACCESS_TYPE; reviewing how that is used elsewhere should guide how to add it in these cases.

Not all of the above cases needed to be fixed in one PR.

This was previously raised as part of discussion in # zulip-terminal > Stream prefixes (messages) and resulted in #719, from which this is split out from (I'm not aware of any outstanding PRs for that). That issue and discussion may provide some additional clarification on the intent here.

@neiljp neiljp added enhancement New feature or request help wanted This issue should be clear enough to work on good first issue Good for newcomers area: UI General user interface update labels Mar 22, 2023
@zulipbot
Copy link
Member

ERROR: Unexpected response from GitHub API.

@supascooopa
Copy link
Collaborator

Hello, I am new to open source and I'd like to give this issue a try if it's still available.

@supascooopa
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @supascooopa! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot
Copy link
Member

zulipbot commented Apr 11, 2023

@supascooopa You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@supascooopa
Copy link
Collaborator

I am still working on it.

@neiljp
Copy link
Collaborator Author

neiljp commented Apr 18, 2023

@supascooopa I can assign you if you're working on this, though it may be easier to push a Work-In-Progress (WIP) pull request, which will also indicate that :)

If you later stop working on it, that will also enable others to build upon your contribution 👍

@zulipbot
Copy link
Member

@supascooopa We noticed that you have not made any updates to this issue or linked PRs for 10 days. Please comment here if you are still actively working on it. Otherwise, we'd appreciate a quick @zulipbot abandon comment so that someone else can claim this issue and continue from where you left off.

If we don't hear back, you will be automatically unassigned in 4 days. Thanks!

@neiljp neiljp changed the title Add stream markers before stream names in Messages column Add stream markers before stream names in message headers Jul 29, 2023
@neiljp neiljp changed the title Add stream markers before stream names in message headers Add markers before stream names (& DMs) in message headers Jul 29, 2023
@neiljp neiljp added this to the Next Release milestone Jul 29, 2023
@neiljp neiljp linked a pull request Jul 29, 2023 that will close this issue
18 tasks
@neiljp
Copy link
Collaborator Author

neiljp commented Jul 29, 2023

@supascooopa Thanks for the work on #1386 👍 I'm marking this as closed and have split out the remaining part into #1420, to clarify what will be necessary.

@neiljp neiljp closed this as completed Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI General user interface update enhancement New feature or request good first issue Good for newcomers help wanted This issue should be clear enough to work on in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants