-
-
Notifications
You must be signed in to change notification settings - Fork 274
Add markers before stream names (& DMs) in message headers #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
ERROR: Unexpected response from GitHub API. |
Hello, I am new to open source and I'd like to give this issue a try if it's still available. |
@zulipbot claim |
Welcome to Zulip, @supascooopa! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
@supascooopa You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
I am still working on it. |
@supascooopa I can assign you if you're working on this, though it may be easier to push a Work-In-Progress (WIP) pull request, which will also indicate that :) If you later stop working on it, that will also enable others to build upon your contribution 👍 |
@supascooopa We noticed that you have not made any updates to this issue or linked PRs for 10 days. Please comment here if you are still actively working on it. Otherwise, we'd appreciate a quick If we don't hear back, you will be automatically unassigned in 4 days. Thanks! |
@supascooopa Thanks for the work on #1386 👍 I'm marking this as closed and have split out the remaining part into #1420, to clarify what will be necessary. |
In the current UI, we don't use a prefix to indicate the type of stream (if relevant):
in the narrow title (eg.zulip-terminal: topic narrow
)zulip-terminal > some topic
)In contrast, see the stream list in the left panel, or the marker which we add when composing a message to different types of stream.
The characters used are looked up using
STREAM_ACCESS_TYPE
; reviewing how that is used elsewhere should guide how to add it in these cases.Not all of the above cases needed to be fixed in one PR.
This was previously raised as part of discussion in # zulip-terminal > Stream prefixes (messages) and resulted in #719, from which this is split out from (I'm not aware of any outstanding PRs for that). That issue and discussion may provide some additional clarification on the intent here.
The text was updated successfully, but these errors were encountered: