Skip to content

Commit 5683c3a

Browse files
committed
lint-hotkeys/symbols: Add direction symbols to hotkeys doc.
Append arrow keys to direction key names. Fixes #945
1 parent 37ae850 commit 5683c3a

File tree

3 files changed

+21
-7
lines changed

3 files changed

+21
-7
lines changed

docs/hotkeys.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@
1717
## Navigation
1818
|Command|Key Combination|
1919
| :--- | :---: |
20-
|Go up / Previous message|<kbd>Up</kbd> / <kbd>K</kbd>|
21-
|Go down / Next message|<kbd>Down</kbd> / <kbd>J</kbd>|
22-
|Go left|<kbd>Left</kbd> / <kbd>H</kbd>|
23-
|Go right|<kbd>Right</kbd> / <kbd>L</kbd>|
20+
|Go up / Previous message|<kbd>Up</kbd> / <kbd>K</kbd>|
21+
|Go down / Next message|<kbd>Down</kbd> / <kbd>J</kbd>|
22+
|Go left|<kbd>Left</kbd> / <kbd>H</kbd>|
23+
|Go right|<kbd>Right</kbd> / <kbd>L</kbd>|
2424
|Scroll up|<kbd>PgUp</kbd> / <kbd>Shift</kbd> + <kbd>K</kbd>|
2525
|Scroll down|<kbd>PgDn</kbd> / <kbd>Shift</kbd> + <kbd>J</kbd>|
2626
|Go to bottom / Last message|<kbd>End</kbd> / <kbd>Shift</kbd> + <kbd>G</kbd>|
@@ -95,7 +95,7 @@
9595
|Cut backwards to the start of the current word|<kbd>Ctrl</kbd> + <kbd>W</kbd>|
9696
|Paste last cut section|<kbd>Ctrl</kbd> + <kbd>Y</kbd>|
9797
|Undo last action|<kbd>Ctrl</kbd> + <kbd>_</kbd>|
98-
|Jump to the previous line|<kbd>Up</kbd> / <kbd>Ctrl</kbd> + <kbd>P</kbd>|
99-
|Jump to the next line|<kbd>Down</kbd> / <kbd>Ctrl</kbd> + <kbd>N</kbd>|
98+
|Jump to the previous line|<kbd>Up</kbd> / <kbd>Ctrl</kbd> + <kbd>P</kbd>|
99+
|Jump to the next line|<kbd>Down</kbd> / <kbd>Ctrl</kbd> + <kbd>N</kbd>|
100100
|Clear compose box|<kbd>Ctrl</kbd> + <kbd>L</kbd>|
101101

tools/lint-hotkeys

+10-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ from zulipterminal.config.keys import (
1111
KEY_BINDINGS,
1212
display_keys_for_command,
1313
)
14+
from zulipterminal.config.symbols import DOWN_ARROW, LEFT_ARROW, RIGHT_ARROW, UP_ARROW
1415

1516

1617
KEYS_FILE = (
@@ -89,6 +90,14 @@ def generate_hotkeys_file() -> None:
8990
print(f"Hot Keys list saved in {OUTPUT_FILE}")
9091

9192

93+
DIRECTION_TO_SYMBOL_MAP = {
94+
"Up": UP_ARROW,
95+
"Down": DOWN_ARROW,
96+
"Left": LEFT_ARROW,
97+
"Right": RIGHT_ARROW,
98+
}
99+
100+
92101
def get_hotkeys_file_string() -> str:
93102
"""
94103
Construct string in form for output to OUTPUT_FILE based on help text
@@ -114,7 +123,7 @@ def get_hotkeys_file_string() -> str:
114123
if len(key) == 1 and key.isupper()
115124
else f"<kbd>{key.capitalize()}</kbd>"
116125
if len(key) == 1
117-
else f"<kbd>{key}</kbd>"
126+
else f"<kbd>{key + DIRECTION_TO_SYMBOL_MAP.get(key, '')}</kbd>"
118127
for key in key_combination.split()
119128
]
120129
)

zulipterminal/config/symbols.py

+5
Original file line numberDiff line numberDiff line change
@@ -86,3 +86,8 @@
8686
bline=_MESSAGE_RECIPIENTS_BOTTOM,
8787
brcorner=_MESSAGE_RECIPIENTS_BOTTOM,
8888
)
89+
90+
LEFT_ARROW = "←" # LEFTWARDS ARROW, U+2190
91+
UP_ARROW = "↑" # UPWARDS ARROW, U+2191
92+
RIGHT_ARROW = "→" # RIGHTWARDS ARROW, U+2192
93+
DOWN_ARROW = "↓" # DOWNWARDS ARROW, U+2193

0 commit comments

Comments
 (0)