Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use max_topic_length instead of hardcoded limit of 60 #307

Open
gnprice opened this issue Sep 20, 2023 · 7 comments · May be fixed by #1413
Open

Use max_topic_length instead of hardcoded limit of 60 #307

gnprice opened this issue Sep 20, 2023 · 7 comments · May be fixed by #1413
Labels
a-api Implementing specific parts of the Zulip server API a-compose Compose box, autocomplete, attaching files/images help wanted
Milestone
M6: Post-launch

Comments

@gnprice
Copy link
Member

gnprice commented Sep 20, 2023

Until recently, the Zulip API specified a fixed maximum length for topics, of 60 characters. This changed a few months ago in zulip/zulip@e68a69e / zulip/zulip#25226 ; the maximum is now taken from the register-queue response, as max_topic_length.

(That value had actually existed in the register-queue response for a few years, but wasn't part of the documented behavior of the send-message endpoint.)

We currently have a constant kMaxTopicLength reflecting the old API. We should instead use max_topic_length.

Chat discussion:
https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.20app.20and.20max_topic_length/near/1643895
@gnprice gnprice added a-compose Compose box, autocomplete, attaching files/images a-api Implementing specific parts of the Zulip server API labels Sep 20, 2023
@gnprice gnprice added this to the Beta milestone Sep 20, 2023
@kehshiba

This comment was marked as off-topic.

Sign in to view
@gnprice

This comment was marked as off-topic.

Sign in to view
@kehshiba

This comment was marked as off-topic.

Sign in to view
@gnprice gnprice modified the milestones: Beta 1, Beta 2 Nov 8, 2023
@gnprice gnprice modified the milestones: Beta 2, Launch Nov 22, 2023
@gnprice gnprice modified the milestones: Launch, B2: Summer 2024 May 9, 2024
@Aman-Sirmaur19

This comment was marked as off-topic.

Sign in to view
@chrisbobbe

This comment was marked as off-topic.

Sign in to view
@lakshya1goel
Copy link
Contributor

Hello, I want to work on this.

@chrisbobbe
Copy link
Collaborator

Please take a look at the Zulip project's guide to getting involved with the code:

https://zulip.readthedocs.io/en/latest/contributing/contributing.html#your-first-codebase-contribution
https://zulip.readthedocs.io/en/latest/contributing/contributing.html#picking-an-issue-to-work-on

@gnprice gnprice mentioned this issue Dec 27, 2024
Open
@chrisbobbe chrisbobbe mentioned this issue Dec 30, 2024
Open
@AhmedTareek AhmedTareek linked a pull request Mar 16, 2025 that will close this issue
Open
AhmedTareek added a commit to AhmedTareek/zulip-flutter that referenced this issue Mar 31, 2025
@AhmedTareek
compose: Use maxTopicLength instead of the hardcoded value
72d6d46 
Fixes zulip#307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-api Implementing specific parts of the Zulip server API a-compose Compose box, autocomplete, attaching files/images help wanted
Projects
Flutter app
Status: No status
Milestone
M6: Post-launch
Development

Successfully merging a pull request may close this issue.

Use max_topic_length instead of hardcoded limit of 60 AhmedTareek/zulip-flutter
5 participants
@gnprice @chrisbobbe @kehshiba @lakshya1goel @Aman-Sirmaur19