Roles support #313

bkimbrough88 · 2020-03-13T04:21:01Z

Enabling the SDK to perform CRUD operations on Roles as well as manage permissions and users on those roles.

Fixes: #307

sendqueery · 2020-03-20T20:13:12Z

This looks good, but appears to be missing support for scoping unless I've missed something?
It looks like it's missing from the API docs, but is mentioned elsewhere in Datadog's docs: https://docs.datadoghq.com/account_management/faq/managing-global-role-permissions/?tab=datadogussite#granting-permissions-within-limited-scopes

From their example:

{
    "data": {
        "type": "permissions",
         "id": <PERMISSION_UUID>,
         "scope": {
             "indexes": [
                 "main",
                 "support"
            ]
        }
    }
}

bkimbrough88 · 2020-03-27T01:23:14Z

You're right, I've added permission scope to the grant permission requests

.dependencies/src/github.com/cenkalti/backoff

.gitignore

roles_test.go

jirikuncar · 2020-04-01T17:01:29Z

organizations.go

+	Data *Organization `json:"data,omitempty"`
+}
+
+// TODO: Fill this out with everything you can get back when getting an organization


This was just a comment that there's much more to Organizations than an ID, but that's all I needed for this implementation. I can easily delete the comment or create an issue for adding Organizations support.

pietdaniel

I worry that it is a bit early for the role permission API to be solidified in the public client. Can we postpone implementing this API while we roadmap the APIs definition internally. Roles Users and Permissions are good to go.

jirikuncar · 2020-04-07T15:47:13Z

roles.go

+	SortNameAsc        Sort = "name"
+	SortNameDesc       Sort = "-name"
+	SortModifiedAtAsc  Sort = "modified_at"
+	SortModifiedAtDesc Sort = "-modified_at"
+	SortUserCountAsc   Sort = "user_count"
+	SortUserCountDesc  Sort = "-user_count"


What about adding SortRolesBy...?

bkimbrough88 · 2020-04-07T17:43:14Z

I worry that it is a bit early for the role permission API to be solidified in the public client. Can we postpone implementing this API while we roadmap the APIs definition internally. Roles Users and Permissions are good to go.

I feel like anything posted in https://docs.datadoghq.com/api should be stable enough to write into an SDK. The caveat being that you then have to maintain that feature in the SDK as the API evolves.

psionn · 2020-04-17T18:19:44Z

permissions.go

+	permissionRequest := Permission{
+		Type:  String("permissions"),
+		Id:    String(permissionId),
+		Scope: scope,


Apologies for the confusion - after investigation earlier we realized the Roles V2 API does not currently support Scope. To use Scope you should use the Roles V1 API.

psionn · 2020-04-17T18:20:27Z

permissions_test.go

+	}
+}
+
+func TestClient_GrantScopedRolePermission(t *testing.T) {


Like above, to use Scoped Permissions you should test against the Roles V1 API.

bkimbrough88 · 2020-04-29T13:30:06Z

Apologies on letting this sit, I'll take care of the PR comments later tonight

* Added code to allow for performing CRUD operations on a role * Added code to allow granting and revoking permissions on a role * Added code to add or remove users on a role * Initial unit tests

* Added remaining role CRUD tests * Added permissions tests

* Ensuring all role methods have at least one unit test * Splitting permissions and organizations data types and methods into their own files

These files should not have ever been added Also enhancing git ignore file to ensure other useless files don't get added

* Removed unnecessary print statement * Reverted git ignore to previous state, will open a new PR with those changes

bkimbrough88 force-pushed the ISSUE-307-roles-support branch from f555caa to d1f37b3 Compare March 13, 2020 04:24

jirikuncar reviewed Mar 31, 2020

View reviewed changes

.dependencies/src/github.com/cenkalti/backoff Outdated Show resolved Hide resolved

jirikuncar reviewed Mar 31, 2020

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

jirikuncar reviewed Mar 31, 2020

View reviewed changes

roles_test.go Outdated Show resolved Hide resolved

jirikuncar added the enhancement label Apr 1, 2020

jirikuncar reviewed Apr 1, 2020

View reviewed changes

pietdaniel suggested changes Apr 3, 2020

View reviewed changes

jirikuncar reviewed Apr 7, 2020

View reviewed changes

psionn reviewed Apr 28, 2020

View reviewed changes

Brandon Kimbrough added 10 commits May 29, 2020 11:40

ISSUE-307 - Initial commit to support roles

4bdb1a1

* Added code to allow for performing CRUD operations on a role * Added code to allow granting and revoking permissions on a role * Added code to add or remove users on a role * Initial unit tests

ISSUE-307 - adding more unit tests

d97c18b

* Added remaining role CRUD tests * Added permissions tests

ISSUE-307 - Finishing vanilla unit tests

7447c8e

* Ensuring all role methods have at least one unit test * Splitting permissions and organizations data types and methods into their own files

ISSUE-307 - Removing idea files

cbae449

ISSUE-307

ebf825b

ISSUE-307 - adding scope to permission grant requests

8e1f6db

ISSUE-307 - making scope be passed in as a pointer

56cbe57

ISSUE-307 - Removing .dependencies and .env files

da61e42

These files should not have ever been added Also enhancing git ignore file to ensure other useless files don't get added

ISSUE-307 - Addressing PR feedback

eeac959

* Removed unnecessary print statement * Reverted git ignore to previous state, will open a new PR with those changes

removing scoped roles and other PR feedback

d380491

bkimbrough88 force-pushed the ISSUE-307-roles-support branch from ea5e21f to d380491 Compare June 10, 2020 00:42

bkimbrough88 requested a review from jirikuncar August 28, 2020 19:30

bkimbrough88 closed this Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Roles support #313

Roles support #313

bkimbrough88 commented Mar 13, 2020

sendqueery commented Mar 20, 2020 •

edited

Loading

bkimbrough88 commented Mar 27, 2020

jirikuncar Apr 1, 2020

bkimbrough88 Apr 7, 2020

pietdaniel left a comment

jirikuncar Apr 7, 2020

bkimbrough88 commented Apr 7, 2020

psionn Apr 17, 2020

psionn Apr 17, 2020

bkimbrough88 commented Apr 29, 2020

Roles support #313

Roles support #313

Conversation

bkimbrough88 commented Mar 13, 2020

sendqueery commented Mar 20, 2020 • edited Loading

bkimbrough88 commented Mar 27, 2020

jirikuncar Apr 1, 2020

Choose a reason for hiding this comment

bkimbrough88 Apr 7, 2020

Choose a reason for hiding this comment

pietdaniel left a comment

Choose a reason for hiding this comment

jirikuncar Apr 7, 2020

Choose a reason for hiding this comment

bkimbrough88 commented Apr 7, 2020

psionn Apr 17, 2020

Choose a reason for hiding this comment

psionn Apr 17, 2020

Choose a reason for hiding this comment

bkimbrough88 commented Apr 29, 2020

sendqueery commented Mar 20, 2020 •

edited

Loading