Skip to content

Allow setting op.Crypto during provider setup #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 2 tasks
MSP-GTI opened this issue Apr 11, 2025 · 1 comment
Open
1 of 2 tasks

Allow setting op.Crypto during provider setup #736

MSP-GTI opened this issue Apr 11, 2025 · 1 comment
Labels
auth enhancement New feature or request

Comments

@MSP-GTI
Copy link

MSP-GTI commented Apr 11, 2025

Preflight Checklist

  • I could not find a solution in the existing issues, docs, nor discussions
  • I have joined the ZITADEL chat

Describe your problem

Currently, it is not possible to set a custom Crypto provider for an oidc provider.
Instead, the library builds its own crypto provider based on the given configuration key.

However, the current implementation uses a CFB mode implementation, which seems to have been deprecated by go itself.

It would be great if library users have the ability to set their own crypto provider. Especially since there already exists a handy interface for the crypto provider.

Describe your ideal solution

Ideally, the library would provide a WithCustomCrypto(crypto Crypto) Option function in order to customize the creation of the oidc provider.

I'm not sure how problematic a deprecated function is as the default implementation, but maybe it is worth considering a new solution for default behaviour too.

Version

3.35.0

Additional Context

It looks like the CFB mode has been deprecated since go version 1.24.0 onwards: https://pkg.go.dev/crypto/[email protected]#NewCFBEncrypter

@MSP-GTI MSP-GTI added the enhancement New feature or request label Apr 11, 2025
@muhlemmer muhlemmer moved this to 📨 Product Backlog in Product Management Apr 30, 2025
@muhlemmer muhlemmer added the auth label Apr 30, 2025
@muhlemmer
Copy link
Collaborator

We are open for a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth enhancement New feature or request
Projects
Status: 📨 Product Backlog
Development

No branches or pull requests

2 participants