Skip to content

Commit dc31146

Browse files
authored
update code to use . instead of / (#432)
## Summary #398 updated the module path from `"/"` to `"."`, but not all code was migrated to the new convention, causing frontend API calls to fail when retrieving joins. @david-zlai – Can you review the code to ensure it fully aligns with the new convention? @sean-zlai – Can you tear down all Docker images and rebuild on this branch to confirm observability works as expected? ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined how configuration names are handled in observability views. Names are now displayed as originally provided without extra formatting, ensuring a consistent and straightforward presentation. The fallback label remains “Unknown” when a name is not available. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent ee41b7c commit dc31146

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

spark/src/main/scala/ai/chronon/spark/scripts/ObservabilityDemo.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,13 +155,12 @@ object ObservabilityDemo {
155155
val name = "dim_user_account_type"
156156
val window = new Window(10, ai.chronon.api.TimeUnit.HOURS)
157157

158-
val joinPath = joinName.replaceFirst("\\.", "/")
159158
logger.info("Looking up current summary series")
160-
val maybeCurrentSummarySeries = driftStore.getSummarySeries(joinPath, startTs, endTs, Some(name)).get
159+
val maybeCurrentSummarySeries = driftStore.getSummarySeries(joinName, startTs, endTs, Some(name)).get
161160
val currentSummarySeries = Await.result(maybeCurrentSummarySeries, Duration.create(10, TimeUnit.SECONDS))
162161
logger.info("Now looking up baseline summary series")
163162
val maybeBaselineSummarySeries =
164-
driftStore.getSummarySeries(joinPath, startTs - window.millis, endTs - window.millis, Some(name))
163+
driftStore.getSummarySeries(joinName, startTs - window.millis, endTs - window.millis, Some(name))
165164
val baselineSummarySeries = Await.result(maybeBaselineSummarySeries.get, Duration.create(10, TimeUnit.SECONDS))
166165

167166
logger.info(s"Current summary series: $currentSummarySeries")

0 commit comments

Comments
 (0)