Skip to content

Commit 9ffb264

Browse files
authored
.DS_Store should be filtered out in all directories (#61)
## Summary **Issue**: The current `.gitignore` patterns are not effectively ignoring `.DS_Store` files across the project. - `**/.DS_Store/`: The trailing slash treats `.DS_Store` as a directory, so it doesn’t match `.DS_Store` files as expected. - `/frontend/.DS_Store`: This only ignores `.DS_Store` files in the root of the `frontend` directory, not in its subdirectories. **Solution**: Using `**/.DS_Store` will correctly ignore `.DS_Store` files in all directories throughout the project, resolving both issues. ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated the `.gitignore` file to better reflect project structure by adding and removing entries for ignored files and directories. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent da1ef7a commit 9ffb264

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

.gitignore

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
.eclipse
1515
**/.vscode/
1616
**/__pycache__/
17-
**/.DS_Store/
17+
**/.DS_Store
1818
api/py/ai/chronon/api/
1919
api/py/test/sample/production/group_bys/quickstart/
2020
api/py/test/sample/production/joins/quickstart/
@@ -57,7 +57,6 @@ releases
5757
/frontend/build
5858

5959
# Frontend OS
60-
/frontend/.DS_Store
6160
/frontend/Thumbs.db
6261

6362
# Frontend Env

0 commit comments

Comments
 (0)