Skip to content

Commit 99a16c9

Browse files
committed
Streamline some pojo stuff
1 parent 0c3e610 commit 99a16c9

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

service/src/main/java/ai/chronon/service/handlers/JoinSchemaHandler.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -42,18 +42,10 @@ public void handle(RoutingContext ctx) {
4242
}
4343

4444
JavaJoinSchemaResponse joinSchemaResponse = joinSchemaResponseTry.getValue();
45-
JsonObject joinSchemaObj = new JsonObject()
46-
.put("joinName", joinSchemaResponse.joinName)
47-
.put("keySchema", joinSchemaResponse.keySchema)
48-
.put("valueSchema", joinSchemaResponse.valueSchema);
49-
50-
JsonObject response =
51-
new JsonObject()
52-
.put("joinSchema", joinSchemaObj)
53-
.put("schemaHash", joinSchemaResponse.schemaHash);
45+
5446
ctx.response()
5547
.setStatusCode(200)
5648
.putHeader("content-type", "application/json")
57-
.end(response.encode());
49+
.end(JsonObject.mapFrom(joinSchemaResponse).encode());
5850
}
5951
}

service/src/test/java/ai/chronon/service/handlers/JoinSchemaHandlerTest.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,15 +84,13 @@ public void testSuccessfulRequest(TestContext context) {
8484
String schemaHash = actualResponse.getString("schemaHash");
8585
context.assertEquals(schemaHash, "fakeschemaHash");
8686

87-
JsonObject returnedJoinSchema = actualResponse.getJsonObject("joinSchema");
88-
89-
String returnedJoinName = returnedJoinSchema.getString("joinName");
87+
String returnedJoinName = actualResponse.getString("joinName");
9088
context.assertEquals(returnedJoinName, "user_join");
9189

92-
String keySchema = returnedJoinSchema.getString("keySchema");
90+
String keySchema = actualResponse.getString("keySchema");
9391
context.assertEquals(keySchema, avroSchemaString);
9492

95-
String valueSchema = returnedJoinSchema.getString("valueSchema");
93+
String valueSchema = actualResponse.getString("valueSchema");
9694
context.assertEquals(valueSchema, avroSchemaString);
9795

9896
// confirm we can parse the avro schema fine

0 commit comments

Comments
 (0)