Skip to content

Commit 65d666a

Browse files
comments
Co-authored-by: Thomas Chow <[email protected]>
1 parent a60537d commit 65d666a

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

build.sbt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,8 @@ lazy val spark = project
190190
libraryDependencies += "com.google.guava" % "guava" % "33.3.1-jre",
191191
libraryDependencies ++= log4j2,
192192
libraryDependencies ++= delta.map(_ % "provided"),
193-
libraryDependencies += "org.json4s" % "json4s-jackson_2.12" % "3.7.0-M11",
194-
libraryDependencies += "org.json4s" %% "json4s-native" % "3.7.0-M11", // Use json4s-native or json4s-jackson
193+
libraryDependencies += "org.json4s" % "json4s-jackson_2.12" % "3.7.0-M11", // This version is pinned to the one spark uses in 3.X.X - see: https://github.com/apache/spark/pull/45838
194+
libraryDependencies += "org.json4s" %% "json4s-native" % "3.7.0-M11",
195195
libraryDependencies += "org.json4s" %% "json4s-core" % "3.7.0-M11",
196196
libraryDependencies += "org.yaml" % "snakeyaml" % "2.3"
197197
)
@@ -220,7 +220,7 @@ lazy val cloud_gcp = project
220220
libraryDependencies += "com.google.cloud.bigdataoss" % "gcsio" % "3.0.3", // need it for https://github.com/GoogleCloudDataproc/hadoop-connectors/blob/master/gcsio/src/main/java/com/google/cloud/hadoop/gcsio/GoogleCloudStorageFileSystem.java
221221
libraryDependencies += "com.google.cloud.bigdataoss" % "util-hadoop" % "3.0.0", // need it for https://github.com/GoogleCloudDataproc/hadoop-connectors/blob/master/util-hadoop/src/main/java/com/google/cloud/hadoop/util/HadoopConfigurationProperty.java
222222
libraryDependencies += "com.google.cloud.spark" %% "spark-bigquery-with-dependencies" % "0.41.0",
223-
libraryDependencies += "org.json4s" % "json4s-jackson_2.12" % "3.7.0-M11", // Fixed version to follow spark: https://github.com/apache/spark/pull/45838
223+
libraryDependencies += "org.json4s" % "json4s-jackson_2.12" % "3.7.0-M11", // This version is pinned to the one spark uses in 3.X.X - see: https://github.com/apache/spark/pull/45838
224224
libraryDependencies += "org.json4s" %% "json4s-native" % "3.7.0-M11",
225225
libraryDependencies += "org.json4s" %% "json4s-core" % "3.7.0-M11",
226226
libraryDependencies += "org.yaml" % "snakeyaml" % "2.3",

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitter.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,10 @@ object DataprocSubmitter {
8989
}
9090

9191
private[cloud_gcp] def loadConfig: SubmitterConf = {
92-
val isO = Option(getClass.getClassLoader.getResourceAsStream("dataproc-submitter-conf.yaml"))
92+
val inputStreamOption = Option(getClass.getClassLoader.getResourceAsStream("dataproc-submitter-conf.yaml"))
9393
val yamlLoader = new Yaml()
9494
implicit val formats: Formats = DefaultFormats
95-
isO
95+
inputStreamOption
9696
.map(Source.fromInputStream)
9797
.map((is) =>
9898
try { is.mkString }

cloud_gcp/src/test/scala/ai/chronon/integrations/cloud_gcp/DataprocSubmitterTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class DataprocSubmitterTest extends AnyFunSuite with MockitoSugar {
4747
BigQueryUtilScala.validateScalaVersionCompatibility()
4848
}
4949

50-
test("Used to iterate locally. Do not enable this in CI/CD!") {
50+
ignore("Used to iterate locally. Do not enable this in CI/CD!") {
5151

5252
val submitter = DataprocSubmitter()
5353
val submittedJobId =

0 commit comments

Comments
 (0)