clean up

Co-authored-by: Thomas Chow <[email protected]>

Author: tchow-zlai

cloud_gcp/src/main/scala/ai/chronon/integrations/cloud_gcp/DelegatingBigQueryMetastoreCatalog.scala

@@ -95,7 +95,6 @@ class DelegatingBigQueryMetastoreCatalog extends CatalogExtension {
     Try { icebergCatalog.loadTable(ident) }
       .recover {
         case _ => {
-          val connectorTable = connectorCatalog.loadTable(ident)
           val tId = ident.namespace().toList match {
             case database :: Nil            => TableId.of(database, ident.name())
             case project :: database :: Nil => TableId.of(project, database, ident.name())
@@ -122,6 +121,7 @@ class DelegatingBigQueryMetastoreCatalog extends CatalogExtension {
                               Map(TableCatalog.PROP_EXTERNAL -> "true", TableCatalog.PROP_LOCATION -> uri))
             }
             case _: StandardTableDefinition => {
+              val connectorTable = connectorCatalog.loadTable(ident)
               DelegatingTable(connectorTable, Map(TableCatalog.PROP_EXTERNAL -> "false"))
             }
             case _ => throw new IllegalStateException(s"Cannot support table of type: ${table.getFriendlyName}")

spark/src/main/scala/ai/chronon/spark/TableUtils.scala

@@ -134,7 +134,7 @@ class TableUtils(@transient val sparkSession: SparkSession) extends Serializable
   }
 
   def loadTable(tableName: String): DataFrame = {
-    sparkSession.sql(s"select * from ${tableName}")
+    sparkSession.sql(s"SELECT * FROM ${tableName}")
     // sparkSession.read.load(DataPointer.from(tableName, sparkSession))
   }
 
@@ -741,16 +741,14 @@ class TableUtils(@transient val sparkSession: SparkSession) extends Serializable
                  rangeWheres: Seq[String],
                  fallbackSelects: Option[Map[String, String]] = None): DataFrame = {
 
-    val dp = DataPointer.from(table, sparkSession)
     var df = sparkSession.sql(s"SELECT * FROM ${table}")
+    // val dp = DataPointer.from(table, sparkSession)
     // var df = sparkSession.read.load(dp)
 
     val selects = QueryUtils.buildSelects(selectMap, fallbackSelects)
 
     logger.info(s""" Scanning data:
-                   |  table: ${dp.tableOrPath.green}
-                   |  options: ${dp.readOptions}
-                   |  format: ${dp.readFormat}
+                   |  table: ${table.green}
                    |  selects:
                    |    ${selects.mkString("\n    ").green}
                    |  wheres: