Skip to content

Commit 24e7268

Browse files
committed
make default online jar and online class.
1 parent d0b3a34 commit 24e7268

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

api/py/ai/chronon/repo/run.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -668,8 +668,8 @@ def _gen_final_args(self, start_ds=None, end_ds=None, override_conf_path=None):
668668
base_args = MODE_ARGS[self.mode].format(
669669
conf_path=override_conf_path if override_conf_path else self.conf,
670670
ds=end_ds if end_ds else self.ds,
671-
online_jar=self.online_jar if not self.dataproc else ZIPLINE_ONLINE_JAR_DEFAULT,
672-
online_class=self.online_class if not self.dataproc else ZIPLINE_ONLINE_CLASS_DEFAULT,
671+
online_jar=self.online_jar,
672+
online_class=self.online_class,
673673
)
674674
override_start_partition_arg = (
675675
" --start-partition-override=" + start_ds if start_ds else ""
@@ -780,7 +780,7 @@ def generate_dataproc_submitter_args(local_files_to_upload_to_gcs: List[str], us
780780

781781
# include chronon jar uri. should also already be in the bucket
782782
chronon_jar_uri = f"{zipline_artifacts_bucket_prefix}-{get_customer_id()}" + \
783-
"/jars/cloud_gcp-assembly-0.1.0-SNAPSHOT.jar"
783+
"/jars/cloud_gcp-assembly-0.1.0-SNAPSHOT.jar"
784784

785785
final_args = (f"{user_args} --additional-conf-path=additional-confs.yaml --gcs_files={gcs_file_args} "
786786
f"--chronon_jar_uri={chronon_jar_uri}")
@@ -851,9 +851,11 @@ def upload_gcs_blob(bucket_name, source_file_name, destination_blob_name):
851851
@click.option("--parallelism", help="break down the backfill range into this number of tasks in parallel. "
852852
"Please use it along with --start-ds and --end-ds and only in manual mode")
853853
@click.option("--repo", help="Path to chronon repo")
854-
@click.option("--online-jar", help="Jar containing Online KvStore & Deserializer Impl. "
855-
"Used for streaming and metadata-upload mode.")
856-
@click.option("--online-class", help="Class name of Online Impl. Used for streaming and metadata-upload mode.")
854+
@click.option("--online-jar", default="ZIPLINE_ONLINE_JAR_DEFAULT",
855+
help="Jar containing Online KvStore & Deserializer Impl. "
856+
"Used for streaming and metadata-upload mode.")
857+
@click.option("--online-class", default="ZIPLINE_ONLINE_CLASS_DEFAULT",
858+
help="Class name of Online Impl. Used for streaming and metadata-upload mode.")
857859
@click.option("--version", help="Chronon version to use.")
858860
@click.option("--spark-version", default="2.4.0", help="Spark version to use for downloading jar.")
859861
@click.option("--spark-submit-path", help="Path to spark-submit")

0 commit comments

Comments
 (0)