Skip to content

Commit 2703bc8

Browse files
kvalojmberg-intel
kvalo
authored and
jmberg-intel
committed
wifi: mac80211: rename ieee80211_tx_status() to ieee80211_tx_status_skb()
make htmldocs warns: Documentation/driver-api/80211/mac80211:109: ./include/net/mac80211.h:5170: WARNING: Duplicate C declaration, also defined at mac80211:1117. Declaration is '.. c:function:: void ieee80211_tx_status (struct ieee80211_hw *hw, struct sk_buff *skb)'. This is because there's a function named ieee80211_tx_status() and a struct named ieee80211_tx_status. This has been discussed previously but no solution found: https://lore.kernel.org/all/[email protected]/ There's also a bug open for three years with no solution in sight: sphinx-doc/sphinx#8313 So I guess we have no other solution than to a workaround this in the code, for example to rename the function to ieee80211_tx_status_skb() to avoid the name conflict. I got the idea for the name from ieee80211_tx_status_noskb() in which the skb is not provided as an argument, instead with ieee80211_tx_status_skb() the skb is provided. Compile tested only. Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Johannes Berg <[email protected]>
1 parent c3e5f5f commit 2703bc8

File tree

16 files changed

+37
-37
lines changed

16 files changed

+37
-37
lines changed

‎Documentation/driver-api/80211/mac80211.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ functions/definitions
120120
ieee80211_rx
121121
ieee80211_rx_ni
122122
ieee80211_rx_irqsafe
123-
ieee80211_tx_status
123+
ieee80211_tx_status_skb
124124
ieee80211_tx_status_ni
125125
ieee80211_tx_status_irqsafe
126126
ieee80211_rts_get

‎drivers/net/wireless/ath/ath12k/dp_tx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ ath12k_dp_tx_htt_tx_complete_buf(struct ath12k_base *ab,
401401
}
402402
}
403403

404-
ieee80211_tx_status(ar->hw, msdu);
404+
ieee80211_tx_status_skb(ar->hw, msdu);
405405
}
406406

407407
static void
@@ -498,7 +498,7 @@ static void ath12k_dp_tx_complete_msdu(struct ath12k *ar,
498498
* Might end up reporting it out-of-band from HTT stats.
499499
*/
500500

501-
ieee80211_tx_status(ar->hw, msdu);
501+
ieee80211_tx_status_skb(ar->hw, msdu);
502502

503503
exit:
504504
rcu_read_unlock();

‎drivers/net/wireless/ath/ath5k/base.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1770,7 +1770,7 @@ ath5k_tx_frame_completed(struct ath5k_hw *ah, struct sk_buff *skb,
17701770
ah->stats.antenna_tx[0]++; /* invalid */
17711771

17721772
trace_ath5k_tx_complete(ah, skb, txq, ts);
1773-
ieee80211_tx_status(ah->hw, skb);
1773+
ieee80211_tx_status_skb(ah->hw, skb);
17741774
}
17751775

17761776
static void

‎drivers/net/wireless/ath/ath9k/htc_drv_txrx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ static void ath9k_htc_tx_process(struct ath9k_htc_priv *priv,
523523
}
524524

525525
/* Send status to mac80211 */
526-
ieee80211_tx_status(priv->hw, skb);
526+
ieee80211_tx_status_skb(priv->hw, skb);
527527
}
528528

529529
static inline void ath9k_htc_tx_drainq(struct ath9k_htc_priv *priv,

‎drivers/net/wireless/ath/ath9k/xmit.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ static void ath_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
9494

9595
if (info->flags & (IEEE80211_TX_CTL_REQ_TX_STATUS |
9696
IEEE80211_TX_STATUS_EOSP)) {
97-
ieee80211_tx_status(hw, skb);
97+
ieee80211_tx_status_skb(hw, skb);
9898
return;
9999
}
100100

‎drivers/net/wireless/broadcom/b43/dma.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1531,9 +1531,9 @@ void b43_dma_handle_txstatus(struct b43_wldev *dev,
15311531
ring->nr_failed_tx_packets++;
15321532
ring->nr_total_packet_tries += status->frame_count;
15331533
#endif /* DEBUG */
1534-
ieee80211_tx_status(dev->wl->hw, meta->skb);
1534+
ieee80211_tx_status_skb(dev->wl->hw, meta->skb);
15351535

1536-
/* skb will be freed by ieee80211_tx_status().
1536+
/* skb will be freed by ieee80211_tx_status_skb().
15371537
* Poison our pointer. */
15381538
meta->skb = B43_DMA_PTR_POISON;
15391539
} else {

‎drivers/net/wireless/broadcom/b43/pio.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ void b43_pio_handle_txstatus(struct b43_wldev *dev,
582582
q->buffer_used -= total_len;
583583
q->free_packet_slots += 1;
584584

585-
ieee80211_tx_status(dev->wl->hw, pack->skb);
585+
ieee80211_tx_status_skb(dev->wl->hw, pack->skb);
586586
pack->skb = NULL;
587587
list_add(&pack->list, &q->packets_list);
588588

‎drivers/net/wireless/intel/iwlwifi/dvm/tx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1247,7 +1247,7 @@ void iwlagn_rx_reply_tx(struct iwl_priv *priv, struct iwl_rx_cmd_buffer *rxb)
12471247

12481248
while (!skb_queue_empty(&skbs)) {
12491249
skb = __skb_dequeue(&skbs);
1250-
ieee80211_tx_status(priv->hw, skb);
1250+
ieee80211_tx_status_skb(priv->hw, skb);
12511251
}
12521252
}
12531253

@@ -1384,6 +1384,6 @@ void iwlagn_rx_reply_compressed_ba(struct iwl_priv *priv,
13841384

13851385
while (!skb_queue_empty(&reclaimed_skbs)) {
13861386
skb = __skb_dequeue(&reclaimed_skbs);
1387-
ieee80211_tx_status(priv->hw, skb);
1387+
ieee80211_tx_status_skb(priv->hw, skb);
13881388
}
13891389
}

‎drivers/net/wireless/intel/iwlwifi/mvm/tx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1724,7 +1724,7 @@ static void iwl_mvm_rx_tx_cmd_single(struct iwl_mvm *mvm,
17241724
RS_DRV_DATA_PACK(lq_color, tx_resp->reduced_tpc);
17251725

17261726
if (likely(!iwl_mvm_time_sync_frame(mvm, skb, hdr->addr1)))
1727-
ieee80211_tx_status(mvm->hw, skb);
1727+
ieee80211_tx_status_skb(mvm->hw, skb);
17281728
}
17291729

17301730
/* This is an aggregation queue or might become one, so we use
@@ -2080,7 +2080,7 @@ static void iwl_mvm_tx_reclaim(struct iwl_mvm *mvm, int sta_id, int tid,
20802080

20812081
while (!skb_queue_empty(&reclaimed_skbs)) {
20822082
skb = __skb_dequeue(&reclaimed_skbs);
2083-
ieee80211_tx_status(mvm->hw, skb);
2083+
ieee80211_tx_status_skb(mvm->hw, skb);
20842084
}
20852085
}
20862086

‎drivers/net/wireless/mediatek/mt7601u/tx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ void mt7601u_tx_status(struct mt7601u_dev *dev, struct sk_buff *skb)
110110
info->flags |= IEEE80211_TX_STAT_ACK;
111111

112112
spin_lock_bh(&dev->mac_lock);
113-
ieee80211_tx_status(dev->hw, skb);
113+
ieee80211_tx_status_skb(dev->hw, skb);
114114
spin_unlock_bh(&dev->mac_lock);
115115
}
116116

‎drivers/net/wireless/ralink/rt2x00/rt2x00dev.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ void rt2x00lib_txdone(struct queue_entry *entry,
533533
*/
534534
if (!(skbdesc_flags & SKBDESC_NOT_MAC80211)) {
535535
if (rt2x00_has_cap_flag(rt2x00dev, REQUIRE_TASKLET_CONTEXT))
536-
ieee80211_tx_status(rt2x00dev->hw, entry->skb);
536+
ieee80211_tx_status_skb(rt2x00dev->hw, entry->skb);
537537
else
538538
ieee80211_tx_status_ni(rt2x00dev->hw, entry->skb);
539539
} else {

‎drivers/net/wireless/st/cw1200/txrx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -994,7 +994,7 @@ void cw1200_skb_dtor(struct cw1200_common *priv,
994994
txpriv->raw_link_id, txpriv->tid);
995995
tx_policy_put(priv, txpriv->rate_id);
996996
}
997-
ieee80211_tx_status(priv->hw, skb);
997+
ieee80211_tx_status_skb(priv->hw, skb);
998998
}
999999

10001000
void cw1200_rx_cb(struct cw1200_common *priv,

‎drivers/net/wireless/ti/wl1251/tx.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ static void wl1251_tx_packet_cb(struct wl1251 *wl,
434434
result->status, wl1251_tx_parse_status(result->status));
435435

436436

437-
ieee80211_tx_status(wl->hw, skb);
437+
ieee80211_tx_status_skb(wl->hw, skb);
438438

439439
wl->tx_frames[result->id] = NULL;
440440
}
@@ -566,7 +566,7 @@ void wl1251_tx_flush(struct wl1251 *wl)
566566
if (!(info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS))
567567
continue;
568568

569-
ieee80211_tx_status(wl->hw, skb);
569+
ieee80211_tx_status_skb(wl->hw, skb);
570570
}
571571

572572
for (i = 0; i < FW_TX_CMPLT_BLOCK_SIZE; i++)
@@ -577,7 +577,7 @@ void wl1251_tx_flush(struct wl1251 *wl)
577577
if (!(info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS))
578578
continue;
579579

580-
ieee80211_tx_status(wl->hw, skb);
580+
ieee80211_tx_status_skb(wl->hw, skb);
581581
wl->tx_frames[i] = NULL;
582582
}
583583
}

‎include/net/mac80211.h

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4911,7 +4911,7 @@ void ieee80211_restart_hw(struct ieee80211_hw *hw);
49114911
* for a single hardware must be synchronized against each other. Calls to
49124912
* this function, ieee80211_rx_ni() and ieee80211_rx_irqsafe() may not be
49134913
* mixed for a single hardware. Must not run concurrently with
4914-
* ieee80211_tx_status() or ieee80211_tx_status_ni().
4914+
* ieee80211_tx_status_skb() or ieee80211_tx_status_ni().
49154915
*
49164916
* This function must be called with BHs disabled and RCU read lock
49174917
*
@@ -4936,7 +4936,7 @@ void ieee80211_rx_list(struct ieee80211_hw *hw, struct ieee80211_sta *sta,
49364936
* for a single hardware must be synchronized against each other. Calls to
49374937
* this function, ieee80211_rx_ni() and ieee80211_rx_irqsafe() may not be
49384938
* mixed for a single hardware. Must not run concurrently with
4939-
* ieee80211_tx_status() or ieee80211_tx_status_ni().
4939+
* ieee80211_tx_status_skb() or ieee80211_tx_status_ni().
49404940
*
49414941
* This function must be called with BHs disabled.
49424942
*
@@ -4961,7 +4961,7 @@ void ieee80211_rx_napi(struct ieee80211_hw *hw, struct ieee80211_sta *sta,
49614961
* for a single hardware must be synchronized against each other. Calls to
49624962
* this function, ieee80211_rx_ni() and ieee80211_rx_irqsafe() may not be
49634963
* mixed for a single hardware. Must not run concurrently with
4964-
* ieee80211_tx_status() or ieee80211_tx_status_ni().
4964+
* ieee80211_tx_status_skb() or ieee80211_tx_status_ni().
49654965
*
49664966
* In process context use instead ieee80211_rx_ni().
49674967
*
@@ -4981,7 +4981,7 @@ static inline void ieee80211_rx(struct ieee80211_hw *hw, struct sk_buff *skb)
49814981
*
49824982
* Calls to this function, ieee80211_rx() or ieee80211_rx_ni() may not
49834983
* be mixed for a single hardware.Must not run concurrently with
4984-
* ieee80211_tx_status() or ieee80211_tx_status_ni().
4984+
* ieee80211_tx_status_skb() or ieee80211_tx_status_ni().
49854985
*
49864986
* @hw: the hardware this frame came in on
49874987
* @skb: the buffer to receive, owned by mac80211 after this call
@@ -4996,7 +4996,7 @@ void ieee80211_rx_irqsafe(struct ieee80211_hw *hw, struct sk_buff *skb);
49964996
*
49974997
* Calls to this function, ieee80211_rx() and ieee80211_rx_irqsafe() may
49984998
* not be mixed for a single hardware. Must not run concurrently with
4999-
* ieee80211_tx_status() or ieee80211_tx_status_ni().
4999+
* ieee80211_tx_status_skb() or ieee80211_tx_status_ni().
50005000
*
50015001
* @hw: the hardware this frame came in on
50025002
* @skb: the buffer to receive, owned by mac80211 after this call
@@ -5172,7 +5172,7 @@ void ieee80211_tx_rate_update(struct ieee80211_hw *hw,
51725172
struct ieee80211_tx_info *info);
51735173

51745174
/**
5175-
* ieee80211_tx_status - transmit status callback
5175+
* ieee80211_tx_status_skb - transmit status callback
51765176
*
51775177
* Call this function for all transmitted frames after they have been
51785178
* transmitted. It is permissible to not call this function for
@@ -5187,13 +5187,13 @@ void ieee80211_tx_rate_update(struct ieee80211_hw *hw,
51875187
* @hw: the hardware the frame was transmitted by
51885188
* @skb: the frame that was transmitted, owned by mac80211 after this call
51895189
*/
5190-
void ieee80211_tx_status(struct ieee80211_hw *hw,
5191-
struct sk_buff *skb);
5190+
void ieee80211_tx_status_skb(struct ieee80211_hw *hw,
5191+
struct sk_buff *skb);
51925192

51935193
/**
51945194
* ieee80211_tx_status_ext - extended transmit status callback
51955195
*
5196-
* This function can be used as a replacement for ieee80211_tx_status
5196+
* This function can be used as a replacement for ieee80211_tx_status_skb()
51975197
* in drivers that may want to provide extra information that does not
51985198
* fit into &struct ieee80211_tx_info.
51995199
*
@@ -5210,7 +5210,7 @@ void ieee80211_tx_status_ext(struct ieee80211_hw *hw,
52105210
/**
52115211
* ieee80211_tx_status_noskb - transmit status callback without skb
52125212
*
5213-
* This function can be used as a replacement for ieee80211_tx_status
5213+
* This function can be used as a replacement for ieee80211_tx_status_skb()
52145214
* in drivers that cannot reliably map tx status information back to
52155215
* specific skbs.
52165216
*
@@ -5238,9 +5238,9 @@ static inline void ieee80211_tx_status_noskb(struct ieee80211_hw *hw,
52385238
/**
52395239
* ieee80211_tx_status_ni - transmit status callback (in process context)
52405240
*
5241-
* Like ieee80211_tx_status() but can be called in process context.
5241+
* Like ieee80211_tx_status_skb() but can be called in process context.
52425242
*
5243-
* Calls to this function, ieee80211_tx_status() and
5243+
* Calls to this function, ieee80211_tx_status_skb() and
52445244
* ieee80211_tx_status_irqsafe() may not be mixed
52455245
* for a single hardware.
52465246
*
@@ -5251,17 +5251,17 @@ static inline void ieee80211_tx_status_ni(struct ieee80211_hw *hw,
52515251
struct sk_buff *skb)
52525252
{
52535253
local_bh_disable();
5254-
ieee80211_tx_status(hw, skb);
5254+
ieee80211_tx_status_skb(hw, skb);
52555255
local_bh_enable();
52565256
}
52575257

52585258
/**
52595259
* ieee80211_tx_status_irqsafe - IRQ-safe transmit status callback
52605260
*
5261-
* Like ieee80211_tx_status() but can be called in IRQ context
5261+
* Like ieee80211_tx_status_skb() but can be called in IRQ context
52625262
* (internally defers to a tasklet.)
52635263
*
5264-
* Calls to this function, ieee80211_tx_status() and
5264+
* Calls to this function, ieee80211_tx_status_skb() and
52655265
* ieee80211_tx_status_ni() may not be mixed for a single hardware.
52665266
*
52675267
* @hw: the hardware the frame was transmitted by

‎net/mac80211/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ static void ieee80211_tasklet_handler(struct tasklet_struct *t)
319319
break;
320320
case IEEE80211_TX_STATUS_MSG:
321321
skb->pkt_type = 0;
322-
ieee80211_tx_status(&local->hw, skb);
322+
ieee80211_tx_status_skb(&local->hw, skb);
323323
break;
324324
default:
325325
WARN(1, "mac80211: Packet is of unknown type %d\n",

‎net/mac80211/status.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1092,7 +1092,7 @@ static void __ieee80211_tx_status(struct ieee80211_hw *hw,
10921092
send_to_cooked, status);
10931093
}
10941094

1095-
void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
1095+
void ieee80211_tx_status_skb(struct ieee80211_hw *hw, struct sk_buff *skb)
10961096
{
10971097
struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
10981098
struct ieee80211_local *local = hw_to_local(hw);
@@ -1111,7 +1111,7 @@ void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
11111111
ieee80211_tx_status_ext(hw, &status);
11121112
rcu_read_unlock();
11131113
}
1114-
EXPORT_SYMBOL(ieee80211_tx_status);
1114+
EXPORT_SYMBOL(ieee80211_tx_status_skb);
11151115

11161116
void ieee80211_tx_status_ext(struct ieee80211_hw *hw,
11171117
struct ieee80211_tx_status *status)

0 commit comments

Comments
 (0)