seo + a11y fixes

zhengkyl · zhengkyl · commit d229ba221a6b · 2025-01-24T20:50:18.000-05:00
diff --git a/src/components/SplitButton.tsx b/src/components/SplitButton.tsx
@@ -39,6 +39,7 @@ export function SplitButton(props: Props) {
         <Popover.Trigger
           class="group border rounded-md rounded-s-none hover:bg-fore-base/5 focus-visible:(outline-none ring-2 ring-fore-base ring-offset-2 ring-offset-back-base) p-2 disabled:(pointer-events-none opacity-50)"
           disabled={props.disabled}
+          aria-label="More download options"
         >
           <ChevronDown
             size={20}
diff --git a/src/components/editor/QrEditor.tsx b/src/components/editor/QrEditor.tsx
@@ -461,7 +461,7 @@ export function Editor(props: Props) {
                         label={key}
                         active={renderKey() === key}
                       >
-                        <img class="rounded-sm" src={thumbs[key]} />
+                        <img class="rounded-sm" src={thumbs[key]} alt="" />
                       </Preview>
                     </ContentMenuTrigger>
                   )}
diff --git a/src/entry-server.tsx b/src/entry-server.tsx
@@ -9,6 +9,11 @@ export default createHandler(() => (
           <meta charset="utf-8" />
           <meta name="viewport" content="width=device-width, initial-scale=1" />
           <link rel="icon" href="/favicon.svg" />
+          <title>qrframe - a code based QR code designer</title>
+          <meta
+            name="description"
+            content="Create beautiful QR codes using Javascript code with this customizable QR code generator."
+          />
           {assets}
         </head>
         <body class="bg-back-base text-fore-base [--un-default-border-color:fg-subtle]">
diff --git a/src/routes/index.tsx b/src/routes/index.tsx
@@ -36,7 +36,7 @@ function Temp() {
     });
   });
 
-  let qrPreview: HTMLDivElement;
+  let qrPreview!: HTMLDivElement;
   let textRef: HTMLTextAreaElement;
 
   const [textFocused, setTextFocused] = createSignal(false);

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@ export function SplitButton(props: Props) {`
`39`	`39`	`<Popover.Trigger`
`40`	`40`	`class="group border rounded-md rounded-s-none hover:bg-fore-base/5 focus-visible:(outline-none ring-2 ring-fore-base ring-offset-2 ring-offset-back-base) p-2 disabled:(pointer-events-none opacity-50)"`
`41`	`41`	`disabled={props.disabled}`
	`42`	`+ aria-label="More download options"`
`42`	`43`	`>`
`43`	`44`	`<ChevronDown`
`44`	`45`	`size={20}`
Original file line number	Diff line number	Diff line change
`@@ -461,7 +461,7 @@ export function Editor(props: Props) {`
`461`	`461`	`label={key}`
`462`	`462`	`active={renderKey() === key}`
`463`	`463`	`>`
`464`		`- <img class="rounded-sm" src={thumbs[key]} />`
	`464`	`+ <img class="rounded-sm" src={thumbs[key]} alt="" />`
`465`	`465`	`</Preview>`
`466`	`466`	`</ContentMenuTrigger>`
`467`	`467`	`)}`