Skip to content

why chord_set must be 3 or 4 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Altheim opened this issue Nov 11, 2021 · 1 comment
Open

why chord_set must be 3 or 4 #1

Altheim opened this issue Nov 11, 2021 · 1 comment

Comments

@Altheim
Copy link

Altheim commented Nov 11, 2021

I try to use another mid to replace mid in demos lead sheet,but found that chord_set must be 3 or 4 which most mids can not satisfy,can it be improved?

@zhaojw1998
Copy link
Owner

I try to use another mid to replace mid in demos lead sheet,but found that chord_set must be 3 or 4 which most mids can not satisfy,can it be improved?

We limited chord_set to be 3 or 4 because the training data of our re-harmonization model have mostly triad and seventh chords. I have modified the code so that it also supports more complex chords. But if it's too complex, the generated results might fail in harmonization. Hope this helps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants