Feat: Global search phase 3 #2035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
finnar-bin
commented
May 10, 2023
finnar-bin
commented
- Added ability to save 50 recent searches
- Show top 5 recent searches on the global search dropdown
- Remove a recent search keyword
- If user-typed keyword exists as a recent search, show it as a recent search item
* task: added sortby filter * task: rename sortby filter * task: add user filter * task: close menu on select * task: add select highlight * task: add date range to date filters * task: set params for daterange filter * task: set active filter text * task: remove date filter * task: pass active daterange value to daterange picker * fix: fixed ts error
* task: added sortby filter * task: rename sortby filter * task: add user filter * task: close menu on select * task: add select highlight * task: add date range to date filters * task: set params for daterange filter * task: set active filter text * task: remove date filter * task: pass active daterange value to daterange picker * fix: fixed ts error * - do not open a new tab when filters are added - unpin specific tab when search queries are present - show search keyword on tab name for the search page * task: sort by function * task: user filter * task: background color update * task: spacing fix * task: date filter func * task: updated result count * task: fixed alignment * task: added no results for filter
* task: added advanced search button * task: added filter button * chore: removed comment * task: added advanced search modal * task: fixed console errors * task: fixed console error * task: add form fields * task: added tooltips
* task: added advanced search button * task: added filter button * chore: removed comment * task: added advanced search modal * task: fixed console errors * task: fixed console error * task: add form fields * task: added tooltips * task: created hook for advance search data * task: moved search data to content search comp * task: added clear all function * task: wire user filter * task: import types * task: moved everything back into the advance search modal * task: moved date config to a separate file & added daterange modal * task: added date handling for single date picker * task: daterange handler * task: wired advance search page * task: wired advance search function * task: spacing and color update * fix: fixed search button not enabling * task: added cypress test scenarios * task: search page cypress tests * task: advance search modal cypress tests * task: added data-cy * task: updated cy get chaining * fix: height fix for the counter * task: added tooltips and changed date filter to modified at * task: vqa updates * task: adjusted border radius
…bal-search-phase-3
* task: always open the dropdown on click * task: add recent searches hook * task: add recent searches to dropdown * task: created separated component for global search items * task: updated subheader style * task: padding updates * task: cleanup * task: unfocus textfield when user selects an item * task: always show user typed value * task: removed comment * task: wire remove recent search * task: save a max of 50 recent search items * task: when user keyword exists as a saved recent search, render it as a recent search * task: hide suggestions when no user-typed keyword is present * task: fixed incorrect icon * task: remove manual JSON.parse/stringify * task: removed deep cloning
…bal-search-phase-3
* task: save search term from advanced search * chore: add package-lock * task: added cypress tests * task: moved search term to a const variable
agalin920
approved these changes
May 11, 2023
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.