Skip to content

Side Navigation Bar: Make Favicon Image Container Background White #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zcolah opened this issue Apr 17, 2023 · 0 comments · Fixed by #2013
Closed

Side Navigation Bar: Make Favicon Image Container Background White #2006

zcolah opened this issue Apr 17, 2023 · 0 comments · Fixed by #2013
Assignees
Labels
enhancement Improvement to an existing feature

Comments

@zcolah
Copy link

zcolah commented Apr 17, 2023

Describe the bug
Currently if a user selects their Favicon to be a PNG image, it may have transparent parts to it. This results in the PNG Image not looking great in our UI. See reference image below.

CleanShot 2023-04-16 at 19 34 52@2x

Solution
May we add a white background (background-paper) to the div container holding the image? This will make the image look a lot better in our UI as compared to now. It would look something like this.

CleanShot 2023-04-16 at 19 37 20@2x

May you also change the object-fit to "contain" instead of "cover" when doing this? This will allow the entire logo to fit in.

@zcolah zcolah added the enhancement Improvement to an existing feature label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants