Skip to content

Commit 78a66be

Browse files
authored
Fix: Dataset items header menu updates (#2297)
* task: hide preview menu for dataset items * task: hide view site generators for dataset items
1 parent 8080c4a commit 78a66be

File tree

2 files changed

+24
-13
lines changed

2 files changed

+24
-13
lines changed

src/apps/content-editor/src/app/views/ItemEdit/components/ItemEditHeader/MoreMenu.tsx

+18-12
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import { ApiType } from "../../../../../../../schema/src/app/components/ModelApi
3030
import { useGetDomainsQuery } from "../../../../../../../../shell/services/accounts";
3131
import { useFilePath } from "../../../../../../../../shell/hooks/useFilePath";
3232
import { DeleteItemDialog } from "./DeleteItemDialog";
33+
import { useGetContentModelsQuery } from "../../../../../../../../shell/services/instance";
3334

3435
export const MoreMenu = () => {
3536
const { modelZUID, itemZUID } = useParams<{
@@ -51,6 +52,9 @@ export const MoreMenu = () => {
5152
const instance = useSelector((state: AppState) => state.instance);
5253
const { data: domains } = useGetDomainsQuery();
5354
const codePath = useFilePath(modelZUID);
55+
const { data: contentModels } = useGetContentModelsQuery();
56+
const type =
57+
contentModels?.find((model) => model.ZUID === modelZUID)?.type ?? "";
5458

5559
const handleCopyClick = (data: string) => {
5660
navigator?.clipboard
@@ -132,18 +136,20 @@ export const MoreMenu = () => {
132136
View Quick Access API
133137
<KeyboardArrowRightRounded color="action" sx={{ ml: "auto" }} />
134138
</MenuItem>
135-
<MenuItem
136-
onClick={(event) => {
137-
setShowApiEndpoints(event.currentTarget);
138-
setApiEndpointType("site-generators");
139-
}}
140-
>
141-
<ListItemIcon>
142-
<DataObjectRounded />
143-
</ListItemIcon>
144-
View Site Generators API
145-
<KeyboardArrowRightRounded color="action" sx={{ ml: "auto" }} />
146-
</MenuItem>
139+
{type !== "dataset" && (
140+
<MenuItem
141+
onClick={(event) => {
142+
setShowApiEndpoints(event.currentTarget);
143+
setApiEndpointType("site-generators");
144+
}}
145+
>
146+
<ListItemIcon>
147+
<DataObjectRounded />
148+
</ListItemIcon>
149+
View Site Generators API
150+
<KeyboardArrowRightRounded color="action" sx={{ ml: "auto" }} />
151+
</MenuItem>
152+
)}
147153
<MenuItem
148154
onClick={() => {
149155
history.push(`/schema/${modelZUID}`);

src/apps/content-editor/src/app/views/ItemEdit/components/ItemEditHeader/index.tsx

+6-1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import { useState } from "react";
3030
import { PreviewMenu } from "./PreviewMenu";
3131
import { styled } from "@mui/system";
3232
import { useGetInstalledAppsQuery } from "../../../../../../../../shell/services/accounts";
33+
import { useGetContentModelsQuery } from "../../../../../../../../shell/services/instance";
3334

3435
const tabs = [
3536
{
@@ -88,12 +89,16 @@ export const ItemEditHeader = ({ saving, onSave }: HeaderProps) => {
8889
const history = useHistory();
8990
const [showDuplicateItemDialog, setShowDuplicateItemDialog] = useState(false);
9091
const { data: installedApps } = useGetInstalledAppsQuery();
92+
const { data: contentModels } = useGetContentModelsQuery();
9193

9294
const item = useSelector(
9395
(state: AppState) =>
9496
state.content[itemZUID] as ContentItemWithDirtyAndPublishing
9597
);
9698

99+
const type =
100+
contentModels?.find((model) => model.ZUID === modelZUID)?.type ?? "";
101+
97102
const layoutsAppInstalled = installedApps?.find(
98103
(app) => app.appZUID === "80-d8abaff6ef-wxs830"
99104
);
@@ -160,7 +165,7 @@ export const ItemEditHeader = ({ saving, onSave }: HeaderProps) => {
160165
>
161166
<ContentCopyRounded fontSize="small" />
162167
</IconButton>
163-
<PreviewMenu />
168+
{type !== "dataset" && <PreviewMenu />}
164169
<ItemEditHeaderActions saving={saving} onSave={onSave} />
165170
</Box>
166171
</Box>

0 commit comments

Comments
 (0)