Merge pull request #7573 from Slowlife01/fixmedia

mauro-balades · web-flow · commit 3c1ca8b70fbb · 2025-04-13T11:41:24.000+02:00
fix(MediaController): remove sharing state when hiding
diff --git a/src/browser/base/zen-components/ZenMediaController.mjs b/src/browser/base/zen-components/ZenMediaController.mjs
@@ -222,6 +222,7 @@
         )
         .then(() => {
           this.mediaControlBar.setAttribute('hidden', 'true');
+          this.mediaControlBar.removeAttribute('media-sharing');
           gZenUIManager.updateTabsToolbar();
           gZenUIManager.restoreScrollbarState();
         });
@@ -235,7 +236,6 @@
         if (this._currentMediaController.isBeingUsedInPIPModeOrFullscreen) return this.hideMediaControls();
 
         this.updatePipButton();
-        this.mediaControlBar.removeAttribute('media-sharing');
       }
 
       const mediaInfoElements = [this.mediaTitle, this.mediaArtist];

Original file line number	Diff line number	Diff line change
`@@ -222,6 +222,7 @@`
`222`	`222`	`)`
`223`	`223`	`.then(() => {`
`224`	`224`	`this.mediaControlBar.setAttribute('hidden', 'true');`
	`225`	`+ this.mediaControlBar.removeAttribute('media-sharing');`
`225`	`226`	`gZenUIManager.updateTabsToolbar();`
`226`	`227`	`gZenUIManager.restoreScrollbarState();`
`227`	`228`	`});`
`@@ -235,7 +236,6 @@`
`235`	`236`	`if (this._currentMediaController.isBeingUsedInPIPModeOrFullscreen) return this.hideMediaControls();`
`236`	`237`
`237`	`238`	`this.updatePipButton();`
`238`		`- this.mediaControlBar.removeAttribute('media-sharing');`
`239`	`239`	`}`
`240`	`240`
`241`	`241`	`const mediaInfoElements = [this.mediaTitle, this.mediaArtist];`