Skip to content

Pretty TypeScript errors #7844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
zisra opened this issue Feb 15, 2024 · 15 comments
Open
1 task done

Pretty TypeScript errors #7844

zisra opened this issue Feb 15, 2024 · 15 comments
Labels
diagnostics Feedback for diagnostics, error messages, logs, etc feature [core label] language An umbrella label for all programming languages syntax behaviors typescript TypeScript programming language support

Comments

@zisra
Copy link

zisra commented Feb 15, 2024

Check for existing issues

  • Completed

Describe the feature

TypeScript errors should be formatted in a similar fashion as pretty-ts-errors.

If applicable, add mockups / screenshots to help present your vision of the feature

image

image

@zisra zisra added admin read feature [core label] labels Feb 15, 2024
@d1y
Copy link
Contributor

d1y commented Feb 15, 2024

This plugin is a mandatory plugin for me in VScode. If Zed can incorporate it, that would be great, haha

@JosephTLyons JosephTLyons added typescript TypeScript programming language support language An umbrella label for all programming languages syntax behaviors diagnostics Feedback for diagnostics, error messages, logs, etc and removed triage labels Feb 16, 2024
@zisra zisra mentioned this issue Feb 25, 2024
1 task
@yoavbls
Copy link

yoavbls commented Mar 1, 2024

Hi there, I'm the creator of pretty-ts-errors
I love Zed, and I would be happy to port it to Zed or collaborate on that.
I know that currently, extensions aren't supported, but I can export the plugin as a TypeScript LSP, and it'll automatically be supported.
The only thing that is missing from that is an option for advanced MD/MDX on hovers on Zed editor.

If someone on the Zed team thinks it's possible please reach me out 🙂

@coolemur
Copy link

coolemur commented Mar 29, 2024

Screenshot 2024-03-29 at 01 22 32

Might be right place to note this: when error message is too long, it doesn't wrap, nor scrolls right, so it is impossible to see whole message or copy error message to clipboard.

Pretty error messages might solve this it one go.

And on top of that: there is no way to close these errors (?). Unless editor is reloaded (?) or other error is opened.

@nckre
Copy link

nckre commented May 14, 2024

Enabling copy for TS errors would also be great. Currently only the code can be copied but not the error itself.

@ethndotsh
Copy link

Seems like extensions are a thing now - would love to see this!!

@yoavbls
Copy link

yoavbls commented Aug 19, 2024

@ethndotsh As far as I know extensions could be just themes and LSPs for now, we'll need the ability to add/edit diagnostics like VSCode allows + custom render for them

@pierresisson

This comment has been minimized.

@nezudevv
Copy link

This would be a fantastic addition. I am also having a hard time reading the returned errors. Maybe its just a side effect of me being used to the vs code plugin 😅

@dan-myles

This comment has been minimized.

@dukcc

This comment was marked as spam.

@nathansobo
Copy link
Contributor

We should take a look at this. I agree that our TypeScript error rendering looks really rough relative to that plugin.

@vladshcherbin
Copy link

Surprised to see such unreadable error messages after using VSCode, the difference is night & day 😅

@tr3bleee

This comment has been minimized.

@ConradIrwin
Copy link
Member

I'm working on redoing our inline diagnostics to use our markdown renderer, and hoping to get that merged early next week.

If someone wants to pair with me on building/porting the logic that takes the diagnostic from the language server and spitting out spiffy markdown, that would be fun. https://cal.com/conradirwin/pairing

@MichalBastrzyk
Copy link

Any updates on this 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostics Feedback for diagnostics, error messages, logs, etc feature [core label] language An umbrella label for all programming languages syntax behaviors typescript TypeScript programming language support
Projects
None yet
Development

No branches or pull requests