Skip to content

Commit 97dcea7

Browse files
dsherretzebreus
authored andcommitted
refactor: move PackageJson to deno_config (denoland#24348)
1 parent 40b2654 commit 97dcea7

28 files changed

+492
-854
lines changed

Cargo.lock

+16-25
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

+2-1
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ console_static_text = "=0.8.1"
101101
data-encoding = "2.3.3"
102102
data-url = "=0.3.0"
103103
deno_cache_dir = "=0.10.0"
104+
deno_config = { version = "=0.17.0", default-features = false }
104105
dlopen2 = "0.6.1"
105106
ecb = "=0.1.2"
106107
elliptic-curve = { version = "0.13.4", features = ["alloc", "arithmetic", "ecdh", "std", "pem"] }
@@ -170,7 +171,7 @@ spki = "0.7.2"
170171
tar = "=0.4.40"
171172
tempfile = "3.4.0"
172173
termcolor = "1.1.3"
173-
thiserror = "1.0.40"
174+
thiserror = "1.0.61"
174175
tokio = { version = "1.36.0", features = ["full"] }
175176
tokio-metrics = { version = "0.3.0", features = ["rt"] }
176177
tokio-util = "0.7.4"

cli/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ winres.workspace = true
6565
[dependencies]
6666
deno_ast = { workspace = true, features = ["bundler", "cjs", "codegen", "proposal", "react", "sourcemap", "transforms", "typescript", "view", "visit"] }
6767
deno_cache_dir = { workspace = true }
68-
deno_config = "=0.16.4"
68+
deno_config = { workspace = true, features = ["deno_json", "package_json"] }
6969
deno_core = { workspace = true, features = ["include_js_files_for_snapshotting"] }
7070
deno_doc = { version = "=0.140.0", features = ["html", "syntect"] }
7171
deno_emit = "=0.43.0"

cli/args/mod.rs

+9-9
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ mod lockfile;
88
pub mod package_json;
99

1010
pub use self::import_map::resolve_import_map;
11-
use self::package_json::PackageJsonDeps;
1211
use ::import_map::ImportMap;
1312
use deno_ast::SourceMapOption;
13+
use deno_config::package_json::PackageJsonDeps;
1414
use deno_core::resolve_url_or_path;
1515
use deno_graph::GraphKind;
1616
use deno_npm::npm_rc::NpmRc;
@@ -537,7 +537,7 @@ fn discover_package_json(
537537
flags: &Flags,
538538
maybe_stop_at: Option<PathBuf>,
539539
current_dir: &Path,
540-
) -> Result<Option<PackageJson>, AnyError> {
540+
) -> Result<Option<Arc<PackageJson>>, AnyError> {
541541
// TODO(bartlomieju): discover for all subcommands, but print warnings that
542542
// `package.json` is ignored in bundle/compile/etc.
543543

@@ -798,7 +798,7 @@ pub struct CliOptions {
798798
maybe_node_modules_folder: Option<PathBuf>,
799799
maybe_vendor_folder: Option<PathBuf>,
800800
maybe_config_file: Option<ConfigFile>,
801-
maybe_package_json: Option<PackageJson>,
801+
maybe_package_json: Option<Arc<PackageJson>>,
802802
npmrc: Arc<ResolvedNpmRc>,
803803
maybe_lockfile: Option<Arc<Mutex<Lockfile>>>,
804804
overrides: CliOptionOverrides,
@@ -813,7 +813,7 @@ impl CliOptions {
813813
initial_cwd: PathBuf,
814814
maybe_config_file: Option<ConfigFile>,
815815
maybe_lockfile: Option<Arc<Mutex<Lockfile>>>,
816-
maybe_package_json: Option<PackageJson>,
816+
maybe_package_json: Option<Arc<PackageJson>>,
817817
npmrc: Arc<ResolvedNpmRc>,
818818
force_global_cache: bool,
819819
) -> Result<Self, AnyError> {
@@ -839,7 +839,7 @@ impl CliOptions {
839839
&initial_cwd,
840840
&flags,
841841
maybe_config_file.as_ref(),
842-
maybe_package_json.as_ref(),
842+
maybe_package_json.as_deref(),
843843
)
844844
.with_context(|| "Resolving node_modules folder.")?;
845845
let maybe_vendor_folder = if force_global_cache {
@@ -949,7 +949,7 @@ impl CliOptions {
949949
let maybe_lock_file = lockfile::discover(
950950
&flags,
951951
maybe_config_file.as_ref(),
952-
maybe_package_json.as_ref(),
952+
maybe_package_json.as_deref(),
953953
)?;
954954
Self::new(
955955
flags,
@@ -1395,8 +1395,8 @@ impl CliOptions {
13951395
&self.maybe_workspace_config
13961396
}
13971397

1398-
pub fn maybe_package_json(&self) -> &Option<PackageJson> {
1399-
&self.maybe_package_json
1398+
pub fn maybe_package_json(&self) -> Option<&Arc<PackageJson>> {
1399+
self.maybe_package_json.as_ref()
14001400
}
14011401

14021402
pub fn npmrc(&self) -> &Arc<ResolvedNpmRc> {
@@ -1414,7 +1414,7 @@ impl CliOptions {
14141414
self
14151415
.maybe_package_json()
14161416
.as_ref()
1417-
.map(package_json::get_local_package_json_version_reqs)
1417+
.map(|p| p.resolve_local_package_json_version_reqs())
14181418
}
14191419
}
14201420

0 commit comments

Comments
 (0)