Apply suggestions from code review

Co-authored-by: Jack Grigg <[email protected]>

Author: nuttycom

components/zcash_address/CHANGELOG.md

@@ -7,13 +7,14 @@ and this library adheres to Rust's notion of
 
 ## [Unreleased]
 
-### Added
-- A blanket impl of `zcash_address::convert::TryFromAddress` for `(NetworkType, T)`
-  has been added to replace the similar impl that had previously been provided
-  bounded by `TryFromRawAddress`.
+### Changed
+- The following methods with generic parameter `T` now require `T: TryFromAddress`
+  instead of `T: TryFromRawAddress`:
+  - `zcash_address::ZcashAddress::convert_if_network`
+  - The blanket `impl zcash_address::TryFromAddress for (NetworkType, T)`
 
 ### Removed
-- `zcash_address::convert::TryFromRawAddress` has been removed. All of its
+- `zcash_address::TryFromRawAddress` has been removed. All of its
   functions can be served by `TryFromAddress` impls, and its presence adds
   complexity and some pitfalls to the API.
 

components/zcash_address/src/kind/unified/address.rs

@@ -63,9 +63,10 @@ impl SealedItem for Receiver {
 ///
 /// ```
 /// # use core::convert::Infallible;
+/// # use zcash_protocol::consensus::NetworkType;
 /// use zcash_address::{
 ///     unified::{self, Container, Encoding},
-///     ConversionError, TryFromRawAddress, ZcashAddress,
+///     ConversionError, TryFromAddress, ZcashAddress,
 /// };
 ///
 /// # #[cfg(not(feature = "std"))]
@@ -80,12 +81,15 @@ impl SealedItem for Receiver {
 ///
 /// // Or we can parse via `ZcashAddress` (which you should do):
 /// struct MyUnifiedAddress(unified::Address);
-/// impl TryFromRawAddress for MyUnifiedAddress {
+/// impl TryFromAddress for MyUnifiedAddress {
 ///     // In this example we aren't checking the validity of the
 ///     // inner Unified Address, but your code should do so!
 ///     type Error = Infallible;
 ///
-///     fn try_from_raw_unified(ua: unified::Address) -> Result<Self, ConversionError<Self::Error>> {
+///     fn try_from_unified(
+///         _net: NetworkType,
+///         ua: unified::Address
+///     ) -> Result<Self, ConversionError<Self::Error>> {
 ///         Ok(MyUnifiedAddress(ua))
 ///     }
 /// }

components/zcash_address/src/lib.rs

@@ -62,7 +62,7 @@
 //! use std::ffi::{CStr, c_char, c_void};
 //! use std::ptr;
 //!
-//! use zcash_address::{ConversionError, ZcashAddress};
+//! use zcash_address::{ConversionError, TryFromAddress, ZcashAddress};
 //! use zcash_protocol::consensus::NetworkType;
 //!
 //! // Functions that return a pointer to a heap-allocated address of the given kind in
@@ -78,6 +78,7 @@
 //!     type Error = &'static str;
 //!
 //!     fn try_from_sapling(
+//!         _net: NetworkType,
 //!         data: [u8; 43],
 //!     ) -> Result<Self, ConversionError<Self::Error>> {
 //!         let parsed = unsafe { addr_from_sapling(data[..].as_ptr()) };
@@ -89,6 +90,7 @@
 //!     }
 //!
 //!     fn try_from_transparent_p2pkh(
+//!         _net: NetworkType,
 //!         data: [u8; 20],
 //!     ) -> Result<Self, ConversionError<Self::Error>> {
 //!         let parsed = unsafe { addr_from_transparent_p2pkh(data[..].as_ptr()) };
@@ -145,8 +147,7 @@ mod kind;
 #[cfg(any(test, feature = "test-dependencies"))]
 pub mod test_vectors;
 
-use convert::Converter;
-pub use convert::{ConversionError, ToAddress, TryFromAddress, UnsupportedAddress};
+pub use convert::{ConversionError, Converter, ToAddress, TryFromAddress, UnsupportedAddress};
 pub use encoding::ParseError;
 pub use kind::unified;
 use kind::unified::Receiver;
@@ -242,11 +243,10 @@ impl ZcashAddress {
 
     /// Converts this address into another type, if it matches the expected network.
     ///
-    /// `convert_if_network` can convert into any type that implements the
-    /// [`TryFromRawAddress`] trait. This enables `ZcashAddress` to be used as a common
-    /// parsing and serialization interface for Zcash addresses, while delegating
-    /// operations on those addresses (such as constructing transactions) to downstream
-    /// crates.
+    /// `convert_if_network` can convert into any type that implements the [`TryFromAddress`]
+    /// trait. This enables `ZcashAddress` to be used as a common parsing and serialization
+    /// interface for Zcash addresses, while delegating operations on those addresses (such as
+    /// constructing transactions) to downstream crates.
     ///
     /// If you want to get the encoded string for this address, use the [`encode`]
     /// method or the [`Display` implementation] via [`address.to_string()`] instead.

zcash_keys/CHANGELOG.md

@@ -7,7 +7,7 @@ and this library adheres to Rust's notion of
 ## [Unreleased]
 
 ### Changed
-- Updated to `zcash_address 0.8.0`
+- Migrated to `zcash_address 0.8`.
 
 ## [0.4.1, 0.5.1, 0.6.1, 0.7.1, 0.8.1] - 2025-05-09
 

zcash_transparent/CHANGELOG.md

@@ -8,7 +8,7 @@ and this library adheres to Rust's notion of
 ## [Unreleased]
 
 ### Changed
-- Updated to `zcash_address 0.8.0`
+- Migrated to `zcash_address 0.8`.
 
 ## [0.2.3] - 2025-04-04