Changing the page name also changes the name of the native window

[vitalogy]

Description

Thanks for NiceGUI, a great framework ... this makes fun :)

The Problem:
We have a program with a main window (native window) in which you can work, but also do the work in your favorite browser.
When the name of a page is changed in the browser, the name of the main window is also changed. That doesn't look good.
The name of the main window should not change and remain with the name it was initialized with.

I think it's because of this PR #3583

Would it be possible to integrate another parameter/switch to decide whether the title of the main window can be changed? This parameter could have the initial value True.

[rodja]

Thanks for reporting this. Can you provide a minimum reproducible code example? This would allow us and the community to help more efficiently. Thanks!
Why is it important to provide a minimal reproducible example?

[falkoschindler]

Minimum example:

from nicegui import ui

ui.button('Change title', on_click=lambda: ui.page_title('New title'))

ui.run(title='Title', native=True)

But to me it feels totally fine to change the window title when calling ui.page_title - exactly as discussed in #3583.

To only change the title in the browser, you could use a custom page_title function:

def page_title(title: str) -> None:
    client = ui.context.client
    client.title = title
    if client.has_socket_connection:
        client.run_javascript(f'document.title = {json.dumps(title)}')

[rodja]

I think it is not obvious that we change the title of the app when using ui.page_title. As @vitalogy described, it even changes the title of the app if the change is called within a separate tab in the web browser. I think it should only change the title if it is called "in the native view".

[falkoschindler]

Ok, looks like we need to introduce a new client.is_native property to only call main_window.set_title for native clients. This could be done with some JavaScript checking for a pywebview object during handshake.
Does anyone want to give it a try?