Merge pull request #10 from mohe2015/lint-fixes

Author: ggrossetie

.github/workflows/test.yml

@@ -1,12 +1,19 @@
 name: "test-local"
-on: push
+on: [push, pull_request]
 jobs:
   test:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v2
     - run: npm ci
+    - name: Testing / Linting
+      run: npm run test
+    - name: Package
+      run: npm run package
+    - name: "Check that packaging didn't create any changes"
+      run: '[ -z "$(git status --porcelain)" ];'
     - name: Annotate
+      if: github.event_name == 'push'
       uses: ./
       with:
         repo-token: ${{ secrets.GITHUB_TOKEN }}

dist/index.js

@@ -321,7 +321,7 @@ const createCheck = async function (octokit, owner, repo, title, ref) {
       repo,
       name: title,
       head_sha: ref,
-      status: 'in_progress',
+      status: 'in_progress'
     })
     return checkRunId
   } catch (err) {
@@ -365,9 +365,9 @@ const stats = function (annotations) {
     annotations.push(annotation)
     return acc
   }, {})
-  const failureCount = (annotationsPerLevel['failure'] || []).length || 0
-  const warningCount = (annotationsPerLevel['warning'] || []).length || 0
-  const noticeCount = (annotationsPerLevel['notice'] || []).length || 0
+  const failureCount = (annotationsPerLevel.failure || []).length || 0
+  const warningCount = (annotationsPerLevel.warning || []).length || 0
+  const noticeCount = (annotationsPerLevel.notice || []).length || 0
   return { failureCount, warningCount, noticeCount }
 }
 
@@ -399,15 +399,15 @@ const booleanValue = function (input) {
   return /^\s*(true|1)\s*$/i.test(input)
 }
 
-const readAnnotationsFile= async function(inputPath) {
+const readAnnotationsFile = async function (inputPath) {
   const ignoreMissingFileValue = Object(_actions_core__WEBPACK_IMPORTED_MODULE_0__.getInput)('ignore-missing-file', { required: false }) || 'true'
   const ignoreMissingFile = booleanValue(ignoreMissingFileValue)
   try {
     const inputContent = await fs__WEBPACK_IMPORTED_MODULE_2__.promises.readFile(inputPath, 'utf8')
     return JSON.parse(inputContent)
   } catch (err) {
     if (err.code === 'ENOENT' && ignoreMissingFile) {
-      Object(_actions_core__WEBPACK_IMPORTED_MODULE_0__.info)(`Ignoring missing file at '${inputPath}' because \'ignore-missing-file\' is true`)
+      Object(_actions_core__WEBPACK_IMPORTED_MODULE_0__.info)(`Ignoring missing file at '${inputPath}' because 'ignore-missing-file' is true`)
       return null
     } else {
       throw err
@@ -421,7 +421,7 @@ async function run () {
     const inputPath = Object(_actions_core__WEBPACK_IMPORTED_MODULE_0__.getInput)('input', { required: true })
     const title = Object(_actions_core__WEBPACK_IMPORTED_MODULE_0__.getInput)('title', { required: false })
 
-    const octokit = new _actions_github__WEBPACK_IMPORTED_MODULE_1__.getOctokit(repoToken)
+    const octokit = Object(_actions_github__WEBPACK_IMPORTED_MODULE_1__.getOctokit)(repoToken)
     const pullRequest = _actions_github__WEBPACK_IMPORTED_MODULE_1__.context.payload.pull_request
     let ref
     if (pullRequest) {
@@ -457,7 +457,7 @@ async function run () {
           start_line: annotation.line,
           end_line: annotation.line,
           ...annotation,
-          annotation_level: annotationLevel,
+          annotation_level: annotationLevel
         }
       })
       await updateCheck(octokit, owner, repo, checkRunId, conclusion, title, summary, annotations)

index.js

@@ -38,7 +38,7 @@ const createCheck = async function (octokit, owner, repo, title, ref) {
       repo,
       name: title,
       head_sha: ref,
-      status: 'in_progress',
+      status: 'in_progress'
     })
     return checkRunId
   } catch (err) {
@@ -82,9 +82,9 @@ const stats = function (annotations) {
     annotations.push(annotation)
     return acc
   }, {})
-  const failureCount = (annotationsPerLevel['failure'] || []).length || 0
-  const warningCount = (annotationsPerLevel['warning'] || []).length || 0
-  const noticeCount = (annotationsPerLevel['notice'] || []).length || 0
+  const failureCount = (annotationsPerLevel.failure || []).length || 0
+  const warningCount = (annotationsPerLevel.warning || []).length || 0
+  const noticeCount = (annotationsPerLevel.notice || []).length || 0
   return { failureCount, warningCount, noticeCount }
 }
 
@@ -116,15 +116,15 @@ const booleanValue = function (input) {
   return /^\s*(true|1)\s*$/i.test(input)
 }
 
-const readAnnotationsFile= async function(inputPath) {
+const readAnnotationsFile = async function (inputPath) {
   const ignoreMissingFileValue = getInput('ignore-missing-file', { required: false }) || 'true'
   const ignoreMissingFile = booleanValue(ignoreMissingFileValue)
   try {
     const inputContent = await fs.readFile(inputPath, 'utf8')
     return JSON.parse(inputContent)
   } catch (err) {
     if (err.code === 'ENOENT' && ignoreMissingFile) {
-      info(`Ignoring missing file at '${inputPath}' because \'ignore-missing-file\' is true`)
+      info(`Ignoring missing file at '${inputPath}' because 'ignore-missing-file' is true`)
       return null
     } else {
       throw err
@@ -138,7 +138,7 @@ async function run () {
     const inputPath = getInput('input', { required: true })
     const title = getInput('title', { required: false })
 
-    const octokit = new getOctokit(repoToken)
+    const octokit = getOctokit(repoToken)
     const pullRequest = context.payload.pull_request
     let ref
     if (pullRequest) {
@@ -174,7 +174,7 @@ async function run () {
           start_line: annotation.line,
           end_line: annotation.line,
           ...annotation,
-          annotation_level: annotationLevel,
+          annotation_level: annotationLevel
         }
       })
       await updateCheck(octokit, owner, repo, checkRunId, conclusion, title, summary, annotations)

package.json

@@ -5,6 +5,7 @@
   "main": "index.js",
   "scripts": {
     "lint": "standard index.js",
+    "lint-fix": "standard --fix index.js",
     "package": "ncc build index.js -o dist",
     "test": "npm run lint"
   },