Skip to content

Commit 235edd8

Browse files
committed
change words and padding according to ux review comments (opendistro-for-elasticsearch#132)
* change words and padding according to ux review comments * fix padding of monitor schedule
1 parent 92b9754 commit 235edd8

File tree

7 files changed

+20
-11
lines changed

7 files changed

+20
-11
lines changed

public/pages/CreateMonitor/components/MonitorDefinition/MonitorDefinition.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@ const onChangeDefinition = (e, form, resetResponse) => {
3131
const selectDefinitions = plugins => {
3232
return plugins === undefined || plugins.indexOf(ES_AD_PLUGIN) == -1
3333
? defaultSelectDefinitions
34-
: [...defaultSelectDefinitions, { value: 'ad', text: 'Define using Anomaly detector' }];
34+
: [...defaultSelectDefinitions, { value: 'ad', text: 'Define using anomaly detector' }];
3535
};
3636

3737
const MonitorDefinition = ({ resetResponse, plugins }) => (
3838
<FormikSelect
3939
name="searchType"
4040
formRow
4141
rowProps={{
42-
label: 'How do you want to define the monitor?',
42+
label: 'Define the monitor',
4343
style: { paddingLeft: '10px' },
4444
}}
4545
inputProps={{

public/pages/CreateMonitor/components/Schedule/Frequencies/Interval.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ const Interval = () => (
4949
inputProps={{ icon: 'clock', min: 1 }}
5050
/>
5151
</EuiFlexItem>
52-
<EuiFlexItem style={{ margin: '0px' }}>
52+
<EuiFlexItem style={{ margin: '2px' }}>
5353
<FormikSelect
5454
name="period.unit"
5555
formRow

public/pages/CreateMonitor/components/Schedule/Frequencies/__snapshots__/Frequencies.test.js.snap

+2-2
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ exports[`Frequencies renders FrequencyPicker 1`] = `
243243
</div>
244244
<div
245245
class="euiFlexItem"
246-
style="margin:0px"
246+
style="margin:2px"
247247
>
248248
<div
249249
class="euiFormRow euiFormRow--hasEmptyLabelSpace"
@@ -347,7 +347,7 @@ exports[`Frequencies renders Interval 1`] = `
347347
</div>
348348
<div
349349
class="euiFlexItem"
350-
style="margin:0px"
350+
style="margin:2px"
351351
>
352352
<div
353353
class="euiFormRow euiFormRow--hasEmptyLabelSpace"

public/pages/CreateMonitor/containers/AnomalyDetectors/AnomalyDetectors.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,11 @@ class AnomalyDetectors extends React.Component {
6565
}
6666
}
6767
return (
68-
<div>
68+
<div
69+
style={{
70+
maxWidth: '390px',
71+
}}
72+
>
6973
<FormikComboBox
7074
name={'detectorId'}
7175
formRow

public/pages/CreateMonitor/containers/AnomalyDetectors/__tests__/__snapshots__/AnomalyDetector.test.js.snap

+7-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,13 @@ exports[`AnomalyDetectors renders 1`] = `
113113
}
114114
}
115115
>
116-
<div>
116+
<div
117+
style={
118+
Object {
119+
"maxWidth": "390px",
120+
}
121+
}
122+
>
117123
<FormikComboBox
118124
fieldProps={
119125
Object {

public/pages/CreateTrigger/containers/DefineTrigger/AnomalyDetectorTrigger.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class AnomalyDetectorTrigger extends React.Component {
5858
thresholdEnum={adValues.anomalyGradeThresholdEnum}
5959
keyFieldName="anomalyDetector.anomalyGradeThresholdEnum"
6060
valueFieldName="anomalyDetector.anomalyGradeThresholdValue"
61-
label="Anomaly grade condition"
61+
label="Anomaly grade threshold"
6262
/>
6363
<EuiSpacer size="xs" />
6464
<AnomaliesChart
@@ -77,7 +77,7 @@ class AnomalyDetectorTrigger extends React.Component {
7777
thresholdEnum={adValues.anomalyConfidenceThresholdEnum}
7878
keyFieldName="anomalyDetector.anomalyConfidenceThresholdEnum"
7979
valueFieldName="anomalyDetector.anomalyConfidenceThresholdValue"
80-
label="Anomaly confidence condition"
80+
label="Anomaly confidence threshold"
8181
/>
8282
<EuiSpacer size="xs" />
8383
<AnomaliesChart

public/pages/MonitorDetails/containers/MonitorDetails.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,7 @@ export default class MonitorDetails extends Component {
297297
external="true"
298298
target="_blank"
299299
>
300-
{detector.name}
301-
<EuiIcon size="s" type="popout" />
300+
{detector.name} <EuiIcon size="s" type="popout" />
302301
</EuiLink>
303302
</EuiText>
304303
</EuiFlexItem>

0 commit comments

Comments
 (0)