Skip to content

Commit 5b7f7a0

Browse files
joeldrapperjoeldrapper
committed
Fix helper casing
Closes #264
1 parent cc5bf76 commit 5b7f7a0

24 files changed

+90
-45
lines changed

‎lib/phlex/rails.rb

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,23 @@ class HelpersCalledBeforeRenderError < StandardError; end
2121
"field_id" => "FieldID",
2222
"font_url" => "FontURL",
2323
"image_url" => "ImageURL",
24-
"javascript_url" => "JavascriptURL",
24+
"javascript_import_module_tag" => "JavaScriptImportModuleTag",
25+
"javascript_importmap_tags" => "JavaScriptImportmapTags",
26+
"javascript_include_tag" => "JavaScriptIncludeTag",
27+
"javascript_path" => "JavaScriptPath",
28+
"javascript_tag" => "JavaScriptTag",
29+
"javascript_url" => "JavaScriptURL",
30+
"path_to_javascript" => "PathToJavaScript",
31+
"path_to_stylesheet" => "PathToStyleSheet",
32+
"rich_textarea" => "RichTextArea",
2533
"sanitize_css" => "SanitizeCSS",
2634
"sgml" => "SGML",
2735
"sms_to" => "SMSTo",
28-
"stylesheet_url" => "StylesheetURL",
36+
"stylesheet_link_tag" => "StyleSheetLinkTag",
37+
"stylesheet_path" => "StyleSheetPath",
38+
"stylesheet_url" => "StyleSheetURL",
39+
"textarea" => "TextArea",
40+
"textarea_tag" => "TextAreaTag",
2941
"url_field" => "URLField",
3042
"url_field_tag" => "URLFieldTag",
3143
"url_for" => "URLFor",
@@ -34,8 +46,8 @@ class HelpersCalledBeforeRenderError < StandardError; end
3446
"url_to_audio" => "URLToAudio",
3547
"url_to_font" => "URLToFont",
3648
"url_to_image" => "URLToImage",
37-
"url_to_javascript" => "URLToJavascript",
38-
"url_to_stylesheet" => "URLToStylesheet",
49+
"url_to_javascript" => "URLToJavaScript",
50+
"url_to_stylesheet" => "URLToStyleSheet",
3951
"url_to_video" => "URLToVideo",
4052
"utf8_enforcer_tag" => "UTF8EnforcerTag",
4153
"video_url" => "VideoURL",

‎lib/phlex/rails/helpers.rb

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,37 @@
11
# frozen_string_literal: true
22

33
module Phlex::Rails::Helpers
4+
# These will not be suggested by RubyLSP, but they work as
5+
# aliases for legacy helper names.
6+
REDIRECTS = {
7+
:CheckBox => :Checkbox,
8+
:CheckBoxTag => :CheckboxTag,
9+
:CollectionCheckBoxes => :CollectionCheckboxes,
10+
:JavascriptImportModuleTag => :JavaScriptImportModuleTag,
11+
:JavascriptImportmapTags => :JavaScriptImportmapTags,
12+
:JavascriptIncludeTag => :JavaScriptIncludeTag,
13+
:JavascriptPath => :JavaScriptPath,
14+
:JavascriptTag => :JavaScriptTag,
15+
:JavascriptURL => :JavaScriptURL,
16+
:PathToJavascript => :PathToJavaScript,
17+
:PathToStylesheet => :PathToStyleSheet,
18+
:RichTextarea => :RichTextArea,
19+
:StylesheetLinkTag => :StyleSheetLinkTag,
20+
:StylesheetPath => :StyleSheetPath,
21+
:StylesheetURL => :StyleSheetURL,
22+
:Textarea => :TextArea,
23+
:TextareaTag => :TextAreaTag,
24+
:URLToJavascript => :URLToJavaScript,
25+
:URLToStylesheet => :URLToStyleSheet,
26+
}.freeze
27+
28+
def self.const_missing(name)
29+
if (new_name = REDIRECTS[name])
30+
mod = const_get(new_name)
31+
const_set(name, mod)
32+
mod
33+
else
34+
super
35+
end
36+
end
437
end

‎lib/phlex/rails/helpers/check_box_tag.rb

Lines changed: 0 additions & 8 deletions
This file was deleted.

‎lib/phlex/rails/helpers/check_box.rb renamed to ‎lib/phlex/rails/helpers/checkbox.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# frozen_string_literal: true
22

3-
module Phlex::Rails::Helpers::CheckBox
3+
module Phlex::Rails::Helpers::Checkbox
44
extend Phlex::Rails::HelperMacros
55

6-
# [Rails Docs](https://api.rubyonrails.org/classes/ActionView/Helpers/FormHelper.html#method-i-check_box)
7-
register_output_helper def check_box(...) = nil
6+
# [Rails Docs](https://api.rubyonrails.org/classes/ActionView/Helpers/FormHelper.html#method-i-checkbox)
7+
register_output_helper def checkbox(...) = nil
88
end

‎lib/phlex/rails/helpers/checkbox_tag.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# frozen_string_literal: true
2+
3+
module Phlex::Rails::Helpers::CheckboxTag
4+
extend Phlex::Rails::HelperMacros
5+
6+
# [Rails Docs](https://api.rubyonrails.org/classes/ActionView/Helpers/FormTagHelper.html#method-i-checkbox_tag)
7+
register_output_helper def checkbox_tag(...) = nil
8+
end

‎lib/phlex/rails/helpers/collection_check_boxes.rb

Lines changed: 0 additions & 8 deletions
This file was deleted.

‎lib/phlex/rails/helpers/collection_checkboxes.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# frozen_string_literal: true
2+
3+
module Phlex::Rails::Helpers::CollectionCheckboxes
4+
extend Phlex::Rails::HelperMacros
5+
6+
# [Rails Docs](https://api.rubyonrails.org/classes/ActionView/Helpers/FormOptionsHelper.html#method-i-collection_checkboxes)
7+
register_builder_yielding_helper def collection_checkboxes(...) = nil
8+
end

‎lib/phlex/rails/helpers/javascript_import_module_tag.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# frozen_string_literal: true
22

3-
module Phlex::Rails::Helpers::JavascriptImportModuleTag
3+
module Phlex::Rails::Helpers::JavaScriptImportModuleTag
44
extend Phlex::Rails::HelperMacros
55

66
# [Rails Docs](https://github.com/rails/importmap-rails)

‎lib/phlex/rails/helpers/javascript_importmap_tags.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# frozen_string_literal: true
22

3-
module Phlex::Rails::Helpers::JavascriptImportmapTags
3+
module Phlex::Rails::Helpers::JavaScriptImportmapTags
44
extend Phlex::Rails::HelperMacros
55

66
# [Rails Docs](https://github.com/rails/importmap-rails)

‎lib/phlex/rails/helpers/javascript_include_tag.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# frozen_string_literal: true
22

3-
module Phlex::Rails::Helpers::JavascriptIncludeTag
3+
module Phlex::Rails::Helpers::JavaScriptIncludeTag
44
extend Phlex::Rails::HelperMacros
55

66
# [Rails Docs](https://api.rubyonrails.org/classes/ActionView/Helpers/AssetTagHelper.html#method-i-javascript_include_tag)

0 commit comments

Comments
 (0)