Skip to content

Commit 36a0334

Browse files
authored
Minor DFIQ fixes (#186)
1 parent 786d99a commit 36a0334

File tree

3 files changed

+27
-9
lines changed

3 files changed

+27
-9
lines changed

src/components/DFIQ/EditDFIQObject.vue

+11-4
Original file line numberDiff line numberDiff line change
@@ -513,11 +513,18 @@ export default {
513513
});
514514
},
515515
createObject() {
516+
let createRequest = {
517+
dfiq_type: this.localObject.type,
518+
dfiq_yaml: this.localObject.dfiq_yaml,
519+
update_indicators: false
520+
};
521+
522+
if (this.localObject.type === "approach") {
523+
createRequest.update_indicators = this.updateApproachIndicators;
524+
}
525+
516526
axios
517-
.post(`/api/v2/dfiq/from_yaml`, {
518-
dfiq_type: this.localObject.type,
519-
dfiq_yaml: this.localObject.dfiq_yaml
520-
})
527+
.post(`/api/v2/dfiq/from_yaml`, createRequest)
521528
.then(response => {
522529
this.$eventBus.emit("displayMessage", {
523530
message: "DFIQ object succesfully created",

src/components/DFIQTree.vue

+10-1
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,13 @@
9797
@deleteSuccess="obj => emitDFIQUpdate(obj)"
9898
@toggle-fullscreen="toggleFullscreen"
9999
/>
100+
<edit-object
101+
v-else
102+
:object="dfiqTree.object"
103+
:is-active="isActive"
104+
@success="obj => (dfiqTree.object = obj)"
105+
@toggle-fullscreen="toggleFullscreen"
106+
/>
100107
</template>
101108
</v-dialog>
102109

@@ -165,10 +172,12 @@ import { DFIQ_TYPES } from "@/definitions/dfiqDefinitions.js";
165172
import { INDICATOR_TYPES } from "@/definitions/indicatorDefinitions.js";
166173
167174
import EditDFIQObject from "@/components/DFIQ/EditDFIQObject.vue";
175+
import EditObject from "@/components/EditObject.vue";
168176
169177
export default {
170178
components: {
171-
EditDFIQObject
179+
EditDFIQObject,
180+
EditObject
172181
},
173182
props: {
174183
dfiqObject: {

src/components/YetiDFIQApproachTemplate.vue

+6-4
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<v-sheet>
33
<div class="text-h6">{{ description.summary }}</div>
44
<div class="yeti-markdown" v-html="markdownifyText(description.details)"></div>
5-
<div class="mt-5">
5+
<div class="mt-5" v-if="description.references.length > 0">
66
<div class="font-weight-bold mb-2">References:</div>
77
<ul class="ml-5">
88
<li class="mb-2" v-for="ref in description.references"><span v-html="markdownifyText(ref)"></span></li>
@@ -13,11 +13,13 @@
1313
</li>
1414
</ul>
1515
</div>
16+
<div v-else class="mt-5"><em>No references</em></div>
1617
</v-sheet>
1718

18-
<v-divider class="my-7"></v-divider>
19+
<v-divider class="my-7" v-if="view.notes.covered.length + view.notes.not_covered.length > 0"></v-divider>
20+
<div class="mt-5" v-else><em>No coverage data</em></div>
1921

20-
<v-card class="dfiq-covered ma-4">
22+
<v-card class="dfiq-covered ma-4" v-if="view.notes.covered.length > 0">
2123
<v-card-title>Covered</v-card-title>
2224
<v-card-text>
2325
<ul>
@@ -26,7 +28,7 @@
2628
</v-card-text>
2729
</v-card>
2830

29-
<v-card class="dfiq-not-covered ma-4">
31+
<v-card class="dfiq-not-covered ma-4" v-if="view.notes.not_covered.length > 0">
3032
<v-card-title>Not covered</v-card-title>
3133
<v-card-text>
3234
<ul>

0 commit comments

Comments
 (0)