Skip to content

Fill in missing APYs #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
murderteeth opened this issue Mar 25, 2025 · 0 comments
Open

Fill in missing APYs #225

murderteeth opened this issue Mar 25, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@murderteeth
Copy link
Collaborator

murderteeth commented Mar 25, 2025

what

We compute apy on external 4626 vaults here,
https://github.com/yearn/kong/blob/main/packages/ingest/abis/erc4626/timeseries/apy/hook.ts#L115

Note that the computation requires the vault to implement convertToAssets in order to compute a price per share. But external 4626 vaults are not guaranteed to implement convertToAssets or the counterpart convertToShares function.

so what

The result is that some of the index's external 4626 vaults incorrectly compute a 0% APY. For example, https://kalani.yearn.farm/erc4626/1/0xbEef047a543E45807105E51A8BBEFCc5950fcfBa

now what

  • Update kong's apy logic to pull both in a multicall then default to convertToAssets
  • Recompute historic APYs on effected external 4626 vaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant