Skip to content

Commit a4cbb15

Browse files
committed
encoding/xml: disable 3/4 tests for golang#43168
I’m not sure what the right fix is for this. Malformed namespaces (leading or trailing colons, more than 1 colon) should result in an error.
1 parent 828298c commit a4cbb15

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/encoding/xml/xml_test.go

+5-3
Original file line numberDiff line numberDiff line change
@@ -1756,9 +1756,11 @@ func testRoundTrip(t *testing.T, input string) {
17561756

17571757
func TestRoundTrip(t *testing.T) {
17581758
tests := map[string]string{
1759-
"leading colon": `<::Test ::foo="bar"><:::Hello></:::Hello><Hello></Hello></::Test>`,
1760-
"trailing colon": `<foo abc:="x"></foo>`,
1761-
"double colon": `<x:y:foo></x:y:foo>`,
1759+
// Disabling these tests because the parser now treats malformed namespaces as an error.
1760+
// See https://github.com/golang/go/issues/43168.
1761+
// "leading colon": `<::Test ::foo="bar"><:::Hello></:::Hello><Hello></Hello></::Test>`,
1762+
// "trailing colon": `<foo abc:="x"></foo>`,
1763+
// "double colon": `<x:y:foo></x:y:foo>`,
17621764
"comments in directives": `<!ENTITY x<!<!-- c1 [ " -->--x --> > <e></e> <!DOCTYPE xxx [ x<!-- c2 " -->--x ]>`,
17631765
}
17641766
for name, input := range tests {

0 commit comments

Comments
 (0)