Skip to content

Commit 2f08a42

Browse files
Yasuhiro KimuraYasuhiro Kimura
authored andcommitted
www/node16: Remove DTrace support to fix build with upcoming binutils 2.41
* With binutils 2.41 build fails as following. LD_LIBRARY_PATH=/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/lib.host:/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj.target/libnode/src; dtrace -64 "-I/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj/gen" -Isrc -C -G -s src/v8ustack.d -o "/wrkdirs/usr/ports/www/node16/work/node-v16.20.1/out/Release/obj.target/libnode/src/node_dtrace_ustack.o" dtrace: failed to compile script src/v8ustack.d: line 1: failed to resolve V8DBG_SMITAG: Unknown variable name * This is because behaviour of objdump has changes with binutils 2.41. [1][2] * On upstream DTrace support itself has been removed with Node.js 19.x. * There is a pull request that says it fixes build error. [3] I tried it but unfortunately it doesn't work as is expected. * Upstream suggests me to remove DTrace support. [4] Reference: nodejs/node#49991 (comment) [1] Reference: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=0a3137ce4c4b38ee8 [2] Reference: nodejs/node#49992 [3] Reference: nodejs/node#49992 (comment) [4]
1 parent 1745375 commit 2f08a42

File tree

2 files changed

+3
-21
lines changed

2 files changed

+3
-21
lines changed

www/node16/Makefile

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PORTNAME= node
22
DISTVERSIONPREFIX= v
33
DISTVERSION= 16.20.1
4-
PORTREVISION?= 1
4+
PORTREVISION?= 2
55
CATEGORIES= www
66
MASTER_SITES= https://nodejs.org/dist/v${DISTVERSION}/
77
PKGNAMESUFFIX= 16
@@ -63,19 +63,8 @@ CONFLICTS_INSTALL= node[0-9][0-9]
6363
REINPLACE_ARGS= -i ''
6464
PORTSCOUT= limit:^16\.
6565

66-
OPTIONS_DEFINE= BUNDLED_SSL COREPACK DOCS DTRACE NLS
67-
OPTIONS_DEFAULT= COREPACK DTRACE
68-
69-
.if !exists(/usr/sbin/dtrace)
70-
OPTIONS_EXCLUDE+= DTRACE
71-
.endif
72-
73-
OPTIONS_EXCLUDE_aarch64= DTRACE
74-
# dt_modtext:/usr/src/cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c(820): arm not implemented
75-
OPTIONS_EXCLUDE_armv6= DTRACE
76-
OPTIONS_EXCLUDE_armv7= DTRACE
77-
OPTIONS_EXCLUDE_powerpc64= DTRACE
78-
OPTIONS_EXCLUDE_powerpc64le= DTRACE
66+
OPTIONS_DEFINE= BUNDLED_SSL COREPACK DOCS NLS
67+
OPTIONS_DEFAULT= COREPACK
7968

8069
OPTIONS_SUB= yes
8170

@@ -89,8 +78,6 @@ BUNDLED_SSL_CONFIGURE_OFF= --openssl-use-def-ca-store \
8978

9079
COREPACK_CONFIGURE_OFF= --without-corepack
9180

92-
DTRACE_CONFIGURE_ON= --with-dtrace
93-
9481
NLS_BUILD_DEPENDS= icu>=69.1:devel/icu
9582
NLS_LIB_DEPENDS= libicui18n.so:devel/icu
9683
NLS_CONFIGURE_ON= --with-intl=system-icu
@@ -133,8 +120,4 @@ post-install:
133120
${RM} -rf ${STAGEDIR}${PREFIX}/share/systemtap
134121
${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/node
135122

136-
post-install-DTRACE-on:
137-
${MKDIR} ${STAGEDIR}${PREFIX}/lib/dtrace
138-
${INSTALL_DATA} ${WRKSRC}/out/Release/node.d ${STAGEDIR}${PREFIX}/lib/dtrace
139-
140123
.include <bsd.port.post.mk>

www/node16/pkg-plist

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,6 @@ include/node/v8-profiler.h
513513
include/node/v8-version.h
514514
include/node/v8.h
515515
include/node/v8config.h
516-
%%DTRACE%%lib/dtrace/node.d
517516
%%COREPACK%%lib/node_modules/corepack/CHANGELOG.md
518517
%%COREPACK%%lib/node_modules/corepack/LICENSE.md
519518
%%COREPACK%%lib/node_modules/corepack/README.md

0 commit comments

Comments
 (0)