Skip to content

Commit 185e778

Browse files
Phillip9587yash-882
authored andcommitted
refactor: Remove Object.setPrototypeOf polyfill (expressjs#6081)
1 parent 9a58d2a commit 185e778

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

History.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
unreleased
2+
========================
3+
4+
* Remove `Object.setPrototypeOf` polyfill
5+
16
5.0.1 / 2024-10-08
27
==========
38

lib/application.js

+8-9
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ var merge = require('utils-merge');
2525
var resolve = require('path').resolve;
2626
var once = require('once')
2727
var Router = require('router');
28-
var setPrototypeOf = require('setprototypeof')
2928

3029
/**
3130
* Module variables.
@@ -117,10 +116,10 @@ app.defaultConfiguration = function defaultConfiguration() {
117116
}
118117

119118
// inherit protos
120-
setPrototypeOf(this.request, parent.request)
121-
setPrototypeOf(this.response, parent.response)
122-
setPrototypeOf(this.engines, parent.engines)
123-
setPrototypeOf(this.settings, parent.settings)
119+
Object.setPrototypeOf(this.request, parent.request)
120+
Object.setPrototypeOf(this.response, parent.response)
121+
Object.setPrototypeOf(this.engines, parent.engines)
122+
Object.setPrototypeOf(this.settings, parent.settings)
124123
});
125124

126125
// setup locals
@@ -168,8 +167,8 @@ app.handle = function handle(req, res, callback) {
168167
res.req = req;
169168

170169
// alter the prototypes
171-
setPrototypeOf(req, this.request)
172-
setPrototypeOf(res, this.response)
170+
Object.setPrototypeOf(req, this.request)
171+
Object.setPrototypeOf(res, this.response)
173172

174173
// setup locals
175174
if (!res.locals) {
@@ -232,8 +231,8 @@ app.use = function use(fn) {
232231
router.use(path, function mounted_app(req, res, next) {
233232
var orig = req.app;
234233
fn.handle(req, res, function (err) {
235-
setPrototypeOf(req, orig.request)
236-
setPrototypeOf(res, orig.response)
234+
Object.setPrototypeOf(req, orig.request)
235+
Object.setPrototypeOf(res, orig.response)
237236
next(err);
238237
});
239238
});

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@
5959
"safe-buffer": "5.2.1",
6060
"send": "^1.1.0",
6161
"serve-static": "^2.1.0",
62-
"setprototypeof": "1.2.0",
6362
"statuses": "2.0.1",
6463
"type-is": "^2.0.0",
6564
"utils-merge": "1.0.1",

0 commit comments

Comments
 (0)