Skip to content

Commit d62578c

Browse files
Fix Integration tests for Big endian on GA CI (#6720)
## What's the problem this PR addresses? Fixes the GA CI Integration jobs failing for Big endian. ## How did you fix it? 1. Changed multiarch image to `tonistiigi/binfmt:latest` for running Big Endian tests as the tests failed in `multiarch/qemu-user-static` image. **Note:** All tests passed on s390x host VM, issues were seen in `multiarch/qemu-user-static` image. Tested running Integration tests using `tonistiigi/binfmt:latest` and all Big Endian Integration tests have passed. 2. Increased `TEST_TIMEOUT` for Big Endian to fix TC's failing due to timeout issue: ## Checklist <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed.
1 parent 3c8a90a commit d62578c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/integration-workflow.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -286,10 +286,10 @@ jobs:
286286
name: yarn-artifacts
287287
path: packages
288288

289-
# https://github.com/multiarch/qemu-user-static
289+
# https://github.com/tonistiigi/binfmt
290290
- name: 'Enable execution of multi-arch containers'
291291
run: |
292-
docker run --rm --privileged multiarch/qemu-user-static --reset --persistent yes
292+
docker run --rm --privileged tonistiigi/binfmt:latest --install all
293293
shell: bash
294294

295295
# Apparently @babel/register is insanely slow inside the big-endian

packages/acceptance-tests/pkg-tests-core/sources/utils/tests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const staticServer = serveStatic(npath.fromPortablePath(require(`pkg-tests-fixtu
2727

2828
// Testing things inside a big-endian container takes forever
2929
export const TEST_TIMEOUT = os.endianness() === `BE`
30-
? 200000
30+
? 300000
3131
: 75000;
3232

3333
export type PackageEntry = Map<string, {path: string, packageJson: Record<string, any>}>;

0 commit comments

Comments
 (0)