Skip to content

Commit c45d9b9

Browse files
authored
fix(plugin-pnp): wait for unplugging to finish before finalizing (#4278)
1 parent df41c95 commit c45d9b9

File tree

2 files changed

+25
-2
lines changed

2 files changed

+25
-2
lines changed

.yarn/versions/d86fbacc.yml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
releases:
2+
"@yarnpkg/cli": patch
3+
"@yarnpkg/plugin-pnp": patch
4+
5+
declined:
6+
- "@yarnpkg/plugin-compat"
7+
- "@yarnpkg/plugin-constraints"
8+
- "@yarnpkg/plugin-dlx"
9+
- "@yarnpkg/plugin-essentials"
10+
- "@yarnpkg/plugin-init"
11+
- "@yarnpkg/plugin-interactive-tools"
12+
- "@yarnpkg/plugin-nm"
13+
- "@yarnpkg/plugin-npm-cli"
14+
- "@yarnpkg/plugin-pack"
15+
- "@yarnpkg/plugin-patch"
16+
- "@yarnpkg/plugin-pnpm"
17+
- "@yarnpkg/plugin-stage"
18+
- "@yarnpkg/plugin-typescript"
19+
- "@yarnpkg/plugin-version"
20+
- "@yarnpkg/plugin-workspace-tools"
21+
- "@yarnpkg/builder"
22+
- "@yarnpkg/core"
23+
- "@yarnpkg/doctor"

packages/plugin-pnp/sources/PnpLinker.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,8 @@ export class PnpInstaller implements Installer {
286286
if (this.opts.project.tryWorkspaceByLocator(pkg))
287287
fallbackExclusionList.push({name: structUtils.stringifyIdent(pkg), reference: pkg.reference});
288288

289+
await this.asyncActions.wait();
290+
289291
await this.finalizeInstallWithPnp({
290292
dependencyTreeRoots,
291293
enableTopLevelFallback,
@@ -296,8 +298,6 @@ export class PnpInstaller implements Installer {
296298
shebang,
297299
});
298300

299-
await this.asyncActions.wait();
300-
301301
return {
302302
customData: this.customData,
303303
};

0 commit comments

Comments
 (0)