chore(file): use const for path in getCandidates (#4281)

trivikr · merceyz · commit 1a9a63c9cfbe · 2023-10-21T15:22:47.000+02:00
* chore(file): use const for path in getCandidates * chore: yarn version check --interactive (cherry picked from commit df41c95)
diff --git a/.yarn/versions/f6c9fb9e.yml b/.yarn/versions/f6c9fb9e.yml
@@ -0,0 +1,5 @@
+releases:
+  "@yarnpkg/plugin-file": patch
+
+declined:
+  - "@yarnpkg/cli"
diff --git a/packages/plugin-file/sources/TarballFileResolver.ts b/packages/plugin-file/sources/TarballFileResolver.ts
@@ -48,10 +48,9 @@ export class TarballFileResolver implements Resolver {
   }
 
   async getCandidates(descriptor: Descriptor, dependencies: unknown, opts: ResolveOptions) {
-    let path = descriptor.range;
-
-    if (path.startsWith(PROTOCOL))
-      path = path.slice(PROTOCOL.length);
+    const path = descriptor.range.startsWith(PROTOCOL)
+      ? descriptor.range.slice(PROTOCOL.length)
+      : descriptor.range;
 
     return [structUtils.makeLocator(descriptor, `${PROTOCOL}${npath.toPortablePath(path)}`)];
   }

Original file line number	Diff line number	Diff line change
`@@ -48,10 +48,9 @@ export class TarballFileResolver implements Resolver {`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`async getCandidates(descriptor: Descriptor, dependencies: unknown, opts: ResolveOptions) {`
`51`		`- let path = descriptor.range;`
`52`		`-`
`53`		`- if (path.startsWith(PROTOCOL))`
`54`		`- path = path.slice(PROTOCOL.length);`
	`51`	`+ const path = descriptor.range.startsWith(PROTOCOL)`
	`52`	`+ ? descriptor.range.slice(PROTOCOL.length)`
	`53`	`+ : descriptor.range;`
`55`	`54`
`56`	`55`	return [structUtils.makeLocator(descriptor, `${PROTOCOL}${npath.toPortablePath(path)}`)];
`57`	`56`	`}`