Skip to content

Commit 0ee6213

Browse files
fix: remove unused --save option for set resolution command (#5868)
The option was never implemented in berry, but it's mentioned in the docs as well as in the CLI output. I don't have the expertise to actually implement the flag, so the second best thing to do here is to remove it, so that people are no longer mislead. **What's the problem this PR addresses?** Mitigates #2202 (actual resolution should be implementing the flag). **How did you fix it?** Removed unnecessary flag. **Checklist** <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed. --------- Co-authored-by: Clement Yan <[email protected]>
1 parent e9e6d0c commit 0ee6213

File tree

2 files changed

+24
-5
lines changed

2 files changed

+24
-5
lines changed

.yarn/versions/3bcde5b8.yml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
releases:
2+
"@yarnpkg/cli": patch
3+
"@yarnpkg/plugin-essentials": patch
4+
5+
declined:
6+
- "@yarnpkg/plugin-compat"
7+
- "@yarnpkg/plugin-constraints"
8+
- "@yarnpkg/plugin-dlx"
9+
- "@yarnpkg/plugin-init"
10+
- "@yarnpkg/plugin-interactive-tools"
11+
- "@yarnpkg/plugin-nm"
12+
- "@yarnpkg/plugin-npm-cli"
13+
- "@yarnpkg/plugin-pack"
14+
- "@yarnpkg/plugin-patch"
15+
- "@yarnpkg/plugin-pnp"
16+
- "@yarnpkg/plugin-pnpm"
17+
- "@yarnpkg/plugin-stage"
18+
- "@yarnpkg/plugin-typescript"
19+
- "@yarnpkg/plugin-version"
20+
- "@yarnpkg/plugin-workspace-tools"
21+
- "@yarnpkg/builder"
22+
- "@yarnpkg/core"
23+
- "@yarnpkg/doctor"

packages/plugin-essentials/sources/commands/set/resolution.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export default class SetResolutionCommand extends BaseCommand {
1414
details: `
1515
This command updates the resolution table so that \`descriptor\` is resolved by \`resolution\`.
1616
17-
Note that by default this command only affect the current resolution table - meaning that this "manual override" will disappear if you remove the lockfile, or if the package disappear from the table. If you wish to make the enforced resolution persist whatever happens, add the \`-s,--save\` flag which will also edit the \`resolutions\` field from your top-level manifest.
17+
Note that by default this command only affect the current resolution table - meaning that this "manual override" will disappear if you remove the lockfile, or if the package disappear from the table. If you wish to make the enforced resolution persist whatever happens, edit the \`resolutions\` field in your top-level manifest.
1818
1919
Note that no attempt is made at validating that \`resolution\` is a valid resolution entry for \`descriptor\`.
2020
`,
@@ -24,10 +24,6 @@ export default class SetResolutionCommand extends BaseCommand {
2424
]],
2525
});
2626

27-
save = Option.Boolean(`-s,--save`, false, {
28-
description: `Persist the resolution inside the top-level manifest`,
29-
});
30-
3127
descriptor = Option.String();
3228
resolution = Option.String();
3329

0 commit comments

Comments
 (0)