Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ControllerAs option for $modal #175

Closed
tamakisquare opened this issue Dec 23, 2014 · 2 comments
Closed

ControllerAs option for $modal #175

tamakisquare opened this issue Dec 23, 2014 · 2 comments

Comments

@tamakisquare
Copy link

it's great that $modal already has support for the controller-as syntax, but the use of it is limited to registered controllers. It's not uncommon to see developers use anonymous function or local function as modal controller, without registering the function as an angular controller beforehand. This is where ControllerAs option comes in. Indeed, this is how it's done in many other popular modules like angular-route, ui-bootstrap, just to name a few.
@tamakisquare tamakisquare mentioned this issue Dec 23, 2014
Merged
@blcook223
Copy link

I have found myself wanting this feature, too. I'd love to see PR #176 implemented.

@jbrowning
Copy link
Member

#176 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbrowning @tamakisquare @blcook223