Review fixes

Author: yakmoose

pkg/api/cloud/image/response.go

@@ -3,7 +3,7 @@ package image
 import "github.com/sitehostnz/gosh/pkg/models"
 
 type (
-	// ListResponse represents the return from the /cloud/images/list_all.json endpoint.
+	// ListResponse represents the return from the /cloud/stack/image/list_all.json endpoint.
 	ListResponse struct {
 		Return struct {
 			models.Pagination

pkg/api/cloud/ssh/user/delete.go

@@ -7,7 +7,7 @@ import (
 	"github.com/sitehostnz/gosh/pkg/utils"
 )
 
-// Delete deletes a cloud database.
+// Delete an existing SSH user.
 func (s *Client) Delete(ctx context.Context, request DeleteRequest) (response DeleteResponse, err error) {
 	uri := "cloud/ssh/user/delete.json"
 	keys := []string{

pkg/api/cloud/ssh/user/list.go

@@ -6,7 +6,7 @@ import (
 	"github.com/sitehostnz/gosh/pkg/utils"
 )
 
-// List returns a list of stack images, specific to the customer.
+// List a list of all SSH users.
 func (s *Client) List(ctx context.Context, options ListOptions) (response ListResponse, err error) {
 	uri := "cloud/ssh/user/list_all.json"
 

pkg/api/cloud/stack/image/response.go

@@ -8,7 +8,4 @@ type (
 		Return []models.StackImage `json:"return"`
 		models.APIResponse
 	}
-
-	// GetResponse returns a single image from the /cloud/stack/images/get.json endpoint.
-	GetResponse struct{}
 )

pkg/api/dns/recordget.go

@@ -38,3 +38,23 @@ func (s *Client) GetRecordWithType(ctx context.Context, request RecordRequest) (
 	}
 	return filteredRecords, nil
 }
+
+// GetRecordWithRecord is a special case, for mainly when we are creating records where we need to get back what we just created.
+//
+// Deprecated: This is only needed for older versions of the Terraform provider as we now get a record ID back.
+func (s *Client) GetRecordWithRecord(ctx context.Context, request models.DNSRecord) (response models.DNSRecord, err error) {
+	records, err := s.ListRecords(ctx, ListRecordsRequest{Domain: request.Domain})
+	if err != nil {
+		return response, err
+	}
+
+	for _, r := range records.Return {
+		if r.Name == request.Name &&
+			r.Type == request.Type &&
+			r.Content == request.Content &&
+			(r.Priority == request.Priority || r.Priority == "0") {
+			return r, nil
+		}
+	}
+	return response, nil
+}

pkg/api/ssh/key/response.go

@@ -3,7 +3,7 @@ package key
 import "github.com/sitehostnz/gosh/pkg/models"
 
 type (
-	// ListResponse represents the listing of SSHKeys.
+	// ListResponse represents the listing of SSH keys.
 	ListResponse struct {
 		Return struct {
 			models.Pagination
@@ -12,7 +12,7 @@ type (
 		models.APIResponse
 	}
 
-	// CreateResponse represents a result of the create an SSH Key call.
+	// CreateResponse represents a result of creating an SSH key.
 	CreateResponse struct {
 		Return struct {
 			KeyID string `json:"key_id"`
@@ -26,12 +26,12 @@ type (
 		models.APIResponse
 	}
 
-	// DeleteResponse represents a result of a delete an SSH Key call.
+	// DeleteResponse represents the result of deleting an SSH key.
 	DeleteResponse struct {
 		models.APIResponse
 	}
 
-	// UpdateResponse represents a result of the update an SSH Key call.
+	// UpdateResponse represents a result of updating an SSH key.
 	UpdateResponse struct {
 		models.APIResponse
 	}

pkg/models/job.go

@@ -1,7 +1,6 @@
 package models
 
 type (
-
 	// JobDetails represents the job information.
 	JobDetails struct {
 		Created   string `json:"created"`

pkg/utils/utils.go

@@ -27,9 +27,7 @@ func Encode(v url.Values, keys []string) string {
 			buf.WriteString(url.QueryEscape(v))
 		}
 	}
-	s := buf.String()
-
-	return s
+	return buf.String()
 }
 
 // AddOptions adds the options to the URL.