Skip to content

Brand extended Express apps with exports instead of true #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2013

Conversation

ericf
Copy link
Collaborator

@ericf ericf commented Oct 17, 2013

This provides a more useful value for the "brand" applied to extended Express apps, the module object itself.

@ericf
Copy link
Collaborator Author

ericf commented Oct 17, 2013

@caridy Do you like this approach instead of simply branding the app's with the value true? I think this will make it easier to compare which version of the module is actually extending the app.

@caridy
Copy link
Contributor

caridy commented Oct 17, 2013

LGTM. most of the components that extends express are already doing that. In the case of express-yui I'm storing a reference to the class used to create app.yui member since it is not exposed thru the module directly, but I might change that to complain with this.

ericf added a commit that referenced this pull request Oct 21, 2013
Brand extended Express apps with `exports` instead of `true`
@ericf ericf merged commit 4206f0d into master Oct 21, 2013
@ericf ericf deleted the brand-with-exports branch October 21, 2013 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants