Skip to content

Ligatures should support detailed ligature types #5284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tyriar opened this issue Jan 8, 2025 · 0 comments · Fixed by #5285
Closed

Ligatures should support detailed ligature types #5284

Tyriar opened this issue Jan 8, 2025 · 0 comments · Fixed by #5285
Assignees
Labels
area/addon/ligatures type/enhancement Features or improvements to existing features
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 8, 2025

VS Code issue: microsoft/vscode#235316

From @joshlawton in microsoft/vscode#34103 (comment)

Just to confirm, this setting only accepts a boolean value and does not enable explicit font-feature-settings like ss01 or cv69? That is, even if terminal.integrated.fontLigatures is true, the font may not necessarily match the style sets and character variants enabled in the editor?

// settings.json

// Works
"terminal.integrated.fontLigatures": true

// Won't work as expected at this time?
"terminal.integrated.fontLigatures": "'calt', 'liga', 'ss19', 'cv69'"

Compare editorOptions.ts to terminalConfiguration.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addon/ligatures type/enhancement Features or improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant