Skip to content

GLOBALMV and NEAR0MV conditions are transposed #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tdaede opened this issue May 13, 2020 · 0 comments · May be fixed by #2322
Open

GLOBALMV and NEAR0MV conditions are transposed #2297

tdaede opened this issue May 13, 2020 · 0 comments · May be fixed by #2322

Comments

@tdaede
Copy link
Collaborator

tdaede commented May 13, 2020 

    if !mv_stack.is_empty() {
      inter_mode_set.push((PredictionMode::NEAR0MV, i));
    }
    if mv_stack.len() >= 2 {
      inter_mode_set.push((PredictionMode::GLOBALMV, i));
    }

I believe the actual intent here was

    if !mv_stack.is_empty() {
      inter_mode_set.push((PredictionMode::GLOBALMV, i));
    }
    if mv_stack.len() >= 2 {
      inter_mode_set.push((PredictionMode::NEAR0MV, i));
    }
@shreevari shreevari linked a pull request May 24, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mixup of GLOBALMV and NEAR0MV shreevari/rav1e
1 participant
@tdaede