Skip to content

Commit feebb8a

Browse files
committed
test-pingpxe: fix identification of ping from busybox
Well, it was indeed working "by chance", as calling readlink on a non-link returns empty, which instead of getting [ to return non-zero because empty string is not "busybox" got it to return non-zero because the comparison operator had no first operand. Signed-off-by: Yann Dirson <[email protected]>
1 parent 1354df4 commit feebb8a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/install/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ def remastered_iso(installer_iso, answerfile):
172172
test "$eth_mac" = "$br_mac"
173173
fi
174174
175-
if [ $(readlink "/bin/ping") = busybox ]; then
175+
if [ "$(readlink /bin/ping)" = busybox ]; then
176176
# XS before 7.0
177177
PINGARGS=""
178178
else

0 commit comments

Comments
 (0)