Skip to content

Commit e976a11

Browse files
committed
fixup! fixup! fixup! fixup! CP-54444: Return MAC addresses to host installer
Signed-off-by: Ming Lu <[email protected]>
1 parent 2679dc3 commit e976a11

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

ocaml/networkd/bin_db/networkd_db.ml

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,9 @@ let _ =
3838
let r =
3939
let* bridge = if !bridge = "" then Error Skip else Ok !bridge in
4040
let* bridge_config =
41-
match List.assoc_opt bridge config.bridge_config with
42-
| Some bridge_config ->
43-
Ok bridge_config
44-
| None ->
45-
Error (Msg (Printf.sprintf "Could not find bridge %s\n" bridge))
41+
let error = Msg (Printf.sprintf "Could not find bridge %s\n" bridge) in
42+
List.assoc_opt bridge config.bridge_config
43+
|> Option.to_result ~none:error
4644
in
4745
let ifaces =
4846
List.concat_map (fun (_, port) -> port.interfaces) bridge_config.ports
@@ -78,11 +76,10 @@ let _ =
7876
in
7977
Printf.printf "interfaces=%s\n" (String.concat "," ifaces) ;
8078
Printf.printf "hwaddrs=%s\n" (String.concat "," macs) ;
81-
match bridge_config.vlan with
82-
| None ->
83-
Ok ()
84-
| Some (parent, id) ->
85-
Ok (Printf.printf "vlan=%d\nparent=%s\n" id parent)
79+
Option.iter
80+
(fun (parent, id) -> Printf.printf "vlan=%d\nparent=%s\n" id parent)
81+
bridge_config.vlan ;
82+
Ok ()
8683
in
8784
( match r with
8885
| Ok () | Error Skip ->

0 commit comments

Comments
 (0)