Skip to content
This repository was archived by the owner on Feb 23, 2024. It is now read-only.

Evaluate if we can move away completely from wordpress/components #2143

Closed
senadir opened this issue Apr 7, 2020 · 3 comments
Closed

Evaluate if we can move away completely from wordpress/components #2143

senadir opened this issue Apr 7, 2020 · 3 comments
Labels
focus: performance The issue/PR is related to performance. status: stale Stale issues and PRs have had no updates for 60 days.

Comments

@senadir
Copy link
Member

senadir commented Apr 7, 2020

This is the most extreme one, currently we use many wordpress/components here and there, the complete list, if we can move away from most of them, we can gain SIGFNIFCANT bundle gains, and reduce the complexity of our bundle and problems we get from supporting many versions, as long as we support 5.3 we will always be a release or two away from fixes and new things, this is 6 months worth of changes, we're not using anything advanced tbh most of those are basic divs .
The idea of sharing code between projects is wonderful in theory, but the fact that you have to support multiple versions and perform extreme gymnastics and still have to use a 6 months old version is not very compelling, if we ever reach a point of version parity with GB or WordPress (which I don'th think is possible) we might find some use in it, currently 4 of those components cause problems:

Both are blocked by the fact that we can update or not (#2140)

The need to update will also be blocking this (or reverse) since if we can update (lesser evil) we solve some issue.

The best solution is to completely move away, which should be investigated before the rest.

the components we use:

assets/js/base/components/cart-checkout/button/index.js:
  4: import { Button as WPButton } from 'wordpress-components';

assets/js/base/components/cart-checkout/shipping-rates-control/package-options.js:
  8: import { Notice } from 'wordpress-components';

assets/js/base/components/cart-checkout/shipping-rates-control/package.js:
  9: import { PanelBody, PanelRow } from 'wordpress-components';

assets/js/base/components/checkbox-control/index.js:
  4: import { CheckboxControl as WPCheckboxControl } from 'wordpress-components';

assets/js/base/components/loading-mask/index.js:
  7: import { Spinner } from 'wordpress-components';

assets/js/base/components/payment-methods/no-payment-methods/index.js:
  5: import { Placeholder } from 'wordpress-components';

assets/js/base/components/select/index.js:
  6: import { CustomSelectControl } from 'wordpress-components';

assets/js/base/components/store-notices-container/snackbar-notices.js:
  4: import { SnackbarList } from 'wordpress-components';

assets/js/blocks/cart-checkout/cart/full-cart/index.js:
  21: import { Card } from 'wordpress-components';
@senadir senadir added the focus: performance The issue/PR is related to performance. label Apr 7, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Remove the stale label or post a comment, otherwise it will be closed in 10 days.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 16, 2020
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Dec 16, 2020
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 15, 2021
@senadir
Copy link
Member Author

senadir commented Feb 15, 2021

We moved away from this solution for some time now when we updated our components version.

@senadir senadir closed this as completed Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: performance The issue/PR is related to performance. status: stale Stale issues and PRs have had no updates for 60 days.
Projects
None yet
Development

No branches or pull requests

2 participants