Fix MemoryBlockStore putBlock return type #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

matheus23 opened this issue Jun 28, 2022 · 0 comments · Fixed by #35

Labels

bug

Member

matheus23 commented Jun 28, 2022

https://github.com/WebNativeFileSystem/rs-wnfs/blob/0a6d8b626751a4d2c7f848a872a5aee477622a40/crates/wasm/examples/graph/src/blockstore.ts#L23-L28

The return type should be Promise<Uint8Array>. The byte array should be a CID, at least from looking at the rust side:

https://github.com/WebNativeFileSystem/rs-wnfs/blob/0a6d8b626751a4d2c7f848a872a5aee477622a40/crates/wasm/fs/blockstore.rs#L60-L68

I think the fix is just a return cid.bytes on the last line of putBlock.

The text was updated successfully, but these errors were encountered:

matheus23 added the bug label

appcypher mentioned this issue

Fix wasm-wnfs issues (type annotations, putBlock signature) #35

Merged

2 tasks

appcypher closed this as completed in #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment